Fatal error: SuperfishBlock::blockValidate must be compatible with SystemMenuBlock::blockValidate [#3607776]

Problem/Motivation

Updating to Drupal 11.4 results in fatal error on database update

Steps to reproduce

composer update drupal/core --with-all-dependencies
when you arrive at the database updates:

[notice] Update started: help_post_update_search_help_dependencies
PHP Fatal error:  Declaration of Drupal\superfish\Plugin\Block\SuperfishBlock::blockValidate($form, Drupal\Core\Form\FormStateInterface $form_state) must be compatible with Drupal\system\Plugin\Block\SystemMenuBlock::blockValidate($form, Drupal\Core\Form\FormStateInterface $form_state): void in /data/sites/web/web/modules/contrib/superfish/src/Plugin/Block/SuperfishBlock.php on line 801
 [warning] Drush command terminated abnormally.
In ProcessBase.php line 155:
  Output is empty.

Proposed resolution

I can try something with AI but... I prefer to report it here :).

Issue fork superfish-3607776

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3607776-fatal-error-superfishblockblockvalidate changes, plain diff MR !25
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

1 July 2026 at 18:40

ttnt created an issue. See original summary.

Comment #2

ttnt commented 1 July 2026 at 18:40

Issue summary:

View changes

Comment #3

1 July 2026 at 19:17

karlshea made their first commit to this issue’s fork.

Comment #4

1 July 2026 at 19:19

karlshea opened merge request !25

Comment #5

karlshea

he/him

English

Minneapolis 🇺🇸

commented 1 July 2026 at 19:25

Status:

Needs work

» Needs review

The issue was that SuperfishBlock::blockValidate needed the void return type added to be compatible with the function declaration that must have changed in Drupal 11.4.