Problem/Motivation

!placeholders are no longer valid in t() strings, but StyledGoogleMapDefaultFormatter::settingsForm() is using them. This causes a 500 error on the ajax request which loads the form when you click the cog for a field on the "Manage display" tab.

Steps to reproduce

  1. Add a Geofield field to a content type
  2. On the "Manage display" form for that content type, change the Format dropdown to "Styled Google Map"
  3. Click the cog on the far right side to set the format settings
  • Expected: The settings form for the Styled Google Map formatter appears
  • Actual: Nothing happens on the front end. On the back end, a 500 is generated.

Proposed resolution

Update the t() calls in StyledGoogleMapDefaultFormatter::settingsForm().

Remaining tasks

Test and merge.

User interface changes

I changed the links to be https across the board.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 update_t_placeholders-3200718-2.patch2.8 KBjoshf

Comments

joshf created an issue. See original summary.

joshf’s picture

StatusFileSize
new2.8 KB

This fixes the issue for me.

joshf’s picture

Assigned: joshf » Unassigned
Status: Active » Needs review

  • a.dmitriiev committed 3bcd703c on 8.x-1.x authored by joshf
    Issue #3200718 by joshf: Can't configure settings under "Manage Display"
    
a.dmitriiev’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.