The SQL Coding Conventions indicate:

Any string literal or %s placeholder must be enclosed by single quotes: ' . Never use double quotes.

The code in stringoverrides.install does the opposite. I will post a patch soon.

CommentFileSizeAuthor
#1 1890570-SQL_coding_conventions_stringoverrides_uninstall-1.patch1.09 KBdooug

Comments

dooug’s picture

dooug commented
Status: Active » Needs review
StatusFileSize
new 1890570-SQL_coding_conventions_stringoverrides_uninstall-1.patch1.09 KB

Patch changes to use single quotes around placeholders. Also, adds proper punctuation on comments ;) Pretty harmless stuff.

robloach’s picture

robloach
he/him
commented
Status: Needs review » Fixed

Thanks! http://drupalcode.org/project/stringoverrides.git/commit/0f065eb

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.