CommentFileSizeAuthor
#3 removing_file_doc_and-2802777-3.patch24.26 KBdishabhadra

Comments

dishabhadra created an issue. See original summary.

dishabhadra’s picture

dishabhadra commented
Issue tags: +Novice 
FILE: .../tests/modules/state_machine_test/src/Guard/FulfillmentGuard.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 10 | ERROR | [x] Missing class doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...ontrib/state_machine/tests/src/Unit/WorkflowGroupManagerTest.php
----------------------------------------------------------------------
FOUND 17 ERRORS AND 3 WARNINGS AFFECTING 18 LINES
----------------------------------------------------------------------
  60 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: ]
  78 | ERROR   | [ ] Doc comment short description must be on a
     |         |     single line, further text should be a separate
     |         |     paragraph
  82 | ERROR   | [x] The first index in a multi-value array must be
     |         |     on a new line
  84 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
  84 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
  85 | ERROR   | [x] The first index in a multi-value array must be
     |         |     on a new line
  87 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
  87 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
  94 | ERROR   | [ ] Missing parameter type
  95 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
     |         |     found 2 spaces
 106 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
 120 | ERROR   | [ ] Missing short description in doc comment
 129 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: ]
 133 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 135 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
 152 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: ]
 156 | ERROR   | [x] Array indentation error, expected 6 spaces but
     |         |     found 8
 158 | ERROR   | [x] Closing parenthesis of array declaration must be
     |         |     on a new line
 164 | ERROR   | [ ] Inline doc block comments are not allowed; use
     |         |     "/* Comment */" or "// Comment" instead
 183 | ERROR   | [x] Expected 1 blank line before function; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...achine/tests/src/Unit/Plugin/WorkflowGroup/WorkflowGroupTest.php
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 43 | ERROR | Missing short description in doc comment
 50 | ERROR | Missing short description in doc comment
 57 | ERROR | Missing short description in doc comment
 64 | ERROR | Missing short description in doc comment
----------------------------------------------------------------------


FILE: ...ib/state_machine/tests/src/Unit/Plugin/Workflow/WorkflowTest.php
----------------------------------------------------------------------
FOUND 83 ERRORS AFFECTING 76 LINES
----------------------------------------------------------------------
   5 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
   6 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
   7 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
   8 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
   9 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
  10 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
  12 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
  16 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
  18 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
  18 | ERROR | [ ] Missing short description in doc comment
  21 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
  22 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  23 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  29 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  31 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  32 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
  34 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
  34 | ERROR | [ ] Missing short description in doc comment
  37 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
  38 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  39 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  44 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  46 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  47 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
  49 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
  49 | ERROR | [ ] Missing short description in doc comment
  53 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
  54 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  55 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  63 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  65 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  66 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  67 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  68 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  69 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
  71 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
  71 | ERROR | [ ] Missing short description in doc comment
  75 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
  76 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  77 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  94 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  96 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  97 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  98 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
  99 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 100 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 101 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 102 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
 104 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
 104 | ERROR | [ ] Missing short description in doc comment
 107 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
 108 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 109 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 134 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 136 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 137 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 138 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 139 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 140 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 141 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 142 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 143 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
 145 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
 145 | ERROR | [ ] Missing short description in doc comment
 148 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
 149 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 175 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 176 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 177 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 6
 178 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 6
 179 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 180 | ERROR | [x] Line indented incorrectly; expected 6 spaces,
     |       |     found 4
 181 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 6
 182 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 6
 183 | ERROR | [x] Line indented incorrectly; expected at least 10
     |       |     spaces, found 8
 184 | ERROR | [x] Line indented incorrectly; expected at least 10
     |       |     spaces, found 8
 185 | ERROR | [x] Line indented incorrectly; expected 8 spaces,
     |       |     found 6
 196 | ERROR | [x] Line indented incorrectly; expected 4 spaces,
     |       |     found 2
 198 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
 202 | ERROR | [x] There must be one blank line after the namespace
     |       |     declaration
 204 | ERROR | [x] Missing function doc comment
 204 | ERROR | [x] Expected 1 blank line before function; 0 found
 206 | ERROR | [x] Expected 1 blank line after function; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 77 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...modules/contrib/state_machine/tests/src/Kernel/StateItemTest.php
----------------------------------------------------------------------
FOUND 7 ERRORS AND 3 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------
  9 | WARNING | [x] Unused use statement
 20 | ERROR   | [ ] If the line declaring an array spans longer than
    |         |     80 characters, each element should be broken into
    |         |     its own line
 22 | ERROR   | [x] Missing function doc comment
 41 | WARNING | [x] A comma should follow the last multiline array
    |         |     item. Found: ]
 46 | ERROR   | [ ] Missing short description in doc comment
 73 | ERROR   | [x] Missing function doc comment
 75 | ERROR   | [ ] If the line declaring an array spans longer than
    |         |     80 characters, each element should be broken into
    |         |     its own line
 76 | ERROR   | [ ] If the line declaring an array spans longer than
    |         |     80 characters, each element should be broken into
    |         |     its own line
 77 | ERROR   | [ ] If the line declaring an array spans longer than
    |         |     80 characters, each element should be broken into
    |         |     its own line
 78 | WARNING | [x] There must be no blank line following an inline
    |         |     comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...l-8.1.9/modules/contrib/state_machine/src/Guard/GuardFactory.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 32 | ERROR | [x] Parameter comment must end with a full stop
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...odules/contrib/state_machine/src/Guard/GuardFactoryInterface.php
----------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 8 LINES
----------------------------------------------------------------------
 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
    |       |     1
 11 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found
 12 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found
 13 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found
 14 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found
 15 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found
 16 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found
 16 | ERROR | [ ] Description for the @return value is missing
 17 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...odules/contrib/state_machine/src/StateMachineServiceProvider.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 12 | ERROR | [x] Expected 1 space before opening brace; found 2
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...contrib/state_machine/src/Plugin/Workflow/WorkflowTransition.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 74 | WARNING | Only string literals should be passed to t() where
    |         | possible
----------------------------------------------------------------------


FILE: ...ules/contrib/state_machine/src/Plugin/Workflow/WorkflowState.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------
 54 | WARNING | [ ] Only string literals should be passed to t()
    |         |     where possible
 60 | ERROR   | [ ] Description for the @return value is missing
 61 | ERROR   | [x] Expected 3 space(s) before asterisk; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
dishabhadra’s picture

dishabhadra commented
Status: Active » Needs review
StatusFileSize
new removing_file_doc_and-2802777-3.patch24.26 KB

Warning are not fixed because as per t() there is no issue so no need to fix.

FILE: ...contrib/state_machine/src/Plugin/Workflow/WorkflowTransition.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 74 | WARNING | Only string literals should be passed to t() where
    |         | possible
----------------------------------------------------------------------


FILE: ...ules/contrib/state_machine/src/Plugin/Workflow/WorkflowState.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 54 | WARNING | Only string literals should be passed to t() where
    |         | possible
----------------------------------------------------------------------
bojanz’s picture

bojanz commented
Status: Needs review » Closed (outdated)

I'll redo this at a later date.