Currently, if there is a a published revision (revision 123) and there is a draft revision (revision 456), an admin can't unpublish the entire node (make in publicly inaccessible) without first activating revision 123. I'll post a post that will allow unpublishing of the entire node even if the active revision is not in a published state.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 1972272-unpublish-forward-revision-3.patch | 6.42 KB | stevector |
| #3 | interdiff-1972272-1-3.txt | 2.81 KB | stevector |
| #1 | 1972272-unpublish-forward-revision.patch | 5.91 KB | stevector |
Comments
Comment #1
stevectorComment #2
stevectorGoing over this with Robeano now. Need to add a test for unpublishing from revisions tab.
Comment #3
stevectorHere are more tests.
Comment #4
stevectorThis patch has a corresponding issue in Workbench Moderation: #1973396: Support unpublishing when there is an active forward revision
Comment #5
robeano commentedI had to make a minor edit to get the tests to run: Updated class state_flow_entity_handler_field_state_flow_states_history_list in the pre_render() method to not pass $values by reference (which is fixed in another issue) - state_flow_entity_handler_field_state_flow_states_history_list.inc line 29.
Tests PASSED. Code reviewed: No changes needed. We're all set here.
Comment #6
stevectorThanks robeano. BTW, the pass-by-reference was fixed in http://drupalcode.org/project/state_machine.git/commit/8aaf3bb9f6e2e4b7c...
I committed this patch in http://drupalcode.org/project/state_machine.git/commit/da8dfc4b391e9c37a...