The current version of spaces_og_db_rewrite_sql blocks terms that are not one of the following:

  1. terms that haven't been used or are on non-OG enabled nodes
  2. terms that are not in a free tagging taxonomy
  3. terms that belong to nodes in a user's groups

What is the reasoning here? Item 2 doesn't make much sense to me except for very specific scenarios. Item 3 prevents an anonymous user from seeing the terms used in a group when displayed via a view. This functionality doesn't seem to make sense for the general usage case of Spaces. Am I wrong?

CommentFileSizeAuthor
#4 og_vocab_compatibility-848638-4.patch1.54 KBrbrandon
#1 848638_spaces_og_db_rewrite_sql_icky.patch1.98 KBhefox

Comments

hefox’s picture

hefox commented
Version: 6.x-3.0-beta4 » 6.x-3.0
Category: support » bug
StatusFileSize
new 848638_spaces_og_db_rewrite_sql_icky.patch1.98 KB

Marking it as a bug, as 404 shouldn't happen when linking to terms from a public group, and there is no way to disable it (other than setting vocabulary to be non tagging.. and using content taxonomy for the fields).

My suggestion is just to ripe it out, or put it in a sub module, or make it configurable.

Patch attached strips it out.

hefox’s picture

hefox commented
Status: Active » Needs review
Grayside’s picture

Grayside commented

Sandboxing vocabularies by group is a great idea, and doing it well would obviate some of the need for OG Vocab and a bunch of custom code I've written.

Bumping, because I think determining what *should* happen is a discussion that should happen.

rbrandon’s picture

rbrandon commented
Version: 6.x-3.0 » 6.x-3.1
StatusFileSize
new og_vocab_compatibility-848638-4.patch1.54 KB

We are using og_vocab to allow for space wide public vocabularies. Below is a patch to allow spaces_og to work with og_vocab till this functionality is expanded. I like the idea of sandboxing vocabularies by group but the concept needs to be expanded a bit.

-Richard