Proxy support

+++ b/src/Plugin/Network/TwitterAuth.php
@@ -84,6 +85,30 @@ class TwitterAuth extends SocialAuthNetwork implements TwitterAuthInterface {
+    $http_client = Settings::get('http_client_config');

Thanks for reporting this and providing a patch. The only change I suggest is to inject the site settings object. Look at other implementers such as Auth Google for guidance on how to do this.

Thanks!

1. +++ b/src/Plugin/Network/TwitterAuth.php
   @@ -62,11 +64,21 @@ class TwitterAuth extends SocialAuthNetwork implements TwitterAuthInterface {
   +  ) {
   

   This should be at the same line as the last parameter

2. +++ b/src/Plugin/Network/TwitterAuth.php
   @@ -62,11 +64,21 @@ class TwitterAuth extends SocialAuthNetwork implements TwitterAuthInterface {
   +    $this->siteSettings = $settings;
   

   siteSettings was not declared before this statement.

3. +++ b/src/Plugin/Network/TwitterAuth.php
   @@ -84,6 +96,10 @@ class TwitterAuth extends SocialAuthNetwork implements TwitterAuthInterface {
   +    if ($proxy = $this->getProxy()) {
   

   Assignment in condition

4. +++ b/src/Plugin/Network/TwitterAuth.php
   @@ -101,8 +117,37 @@ class TwitterAuth extends SocialAuthNetwork implements TwitterAuthInterface {
   +    $proxyUrl = $this->siteSettings->get('http_client_config')['proxy']['https'] ?? NULL;
   

   Coalescing operator is only supported in PHP 7

Remember to change the status to Needs review.

Thanks!

+++ b/src/Plugin/Network/TwitterAuth.php
@@ -101,8 +124,42 @@ class TwitterAuth extends SocialAuthNetwork implements TwitterAuthInterface {
+    $proxyUrl = $this->siteSettings->get('http_client_config')['proxy']['https']
+      ? $this->siteSettings->get('http_client_config')['proxy']['https']
+      : NULL;

Method get returns NULL if setting was not set. So, I guess you can just do $proxyUrl = $this->siteSettings->get('http_client_config')['proxy']['http'];

Also, remember to include interdiff.

Thanks!

Sorry for re-opening the issue but... As seen in the attached image it throws me an error after the login.

I have put a simple checking line with an isset before getting $this->siteSettings->get('http_client_config')['proxy']['https'] and now it works ok for me.

private function getProxy() {
    $proxy = NULL;
    if(isset($this->siteSettings->get('http_client_config')['proxy'])){   
      $proxyUrl = $this->siteSettings->get('http_client_config')['proxy']['https'];

      if ($proxyUrl) {
        $proxy_settings = parse_url($proxyUrl);

        if ($proxy_settings) {
          $proxy = [
            'CURLOPT_PROXY' => $proxy_settings['host'],
            'CURLOPT_PROXYUSERPWD' => "{$proxy_settings['user']}:{$proxy_settings['pass']}",
            'CURLOPT_PROXYPORT' => $proxy_settings['port'],
          ];
        }
      }    
    }
    return $proxy;
  }

May it helps.

I have already the patch installed.