Problem/Motivation

When someone is editing the all-day event, that event can go back one day in time each time it is edited.

E.G. As a user with Amsterdam time timezone I created an event, and then as a user with New York timezone I'll edit that event, the event date will be converted to New York timezone and that is correct, but after saving the date in the database will be changes to new one and it's wrong, because event go back one day in time.

Steps to reproduce

  • Create the all-day event as a user with Amsterdam time timezone
  • Go edit that event as a user with New York timezone
  • Each time when you will edit that event under user with New York timezone, that event will go back one day in time

Proposed resolution

The data that event is all day is not saved anywhere. So, here's two ways:

  • We can add a custom field to the event (field_all_day)
  • We can save that data to State API

I decide to go with second one, since this issue is critical and the second way is faster and with second solution we can always move to first one because State API also saves data to the database.

Remaining tasks

Remove all custom logic with 0:01.

User interface changes

No.

API changes

The method social_event_date_is_all_day was changed. New social_event_date_set_all_day method was added.

Data model changes

No.

Comments

rolki created an issue. See original summary.

rolki’s picture

rolki’s picture

Status: Active » Needs review

Please review my PR to resolve the issue: https://github.com/goalgorilla/open_social/pull/2539

  • navneet0693 committed 654bae8 on 10.3.x
    Merge pull request #2539 from goalgorilla/issue/3241260
    
    Issue #3241260...

navneet0693 credited ribel.

navneet0693’s picture

Status: Needs review » Reviewed & tested by the community
navneet0693’s picture

Status: Reviewed & tested by the community » Fixed

This will be available in Open Social 10.3.2 onwards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.