This is another one where mimemail module and SMTP together are causing trouble. Sine the mimemail project released their beta4 early this month, they are including a space after the colon in header fields (see #2404719: Missing Space in RFC Headers Breaks DKIM) and that is going to break other functionality down the road.

A simple trim() in SmtpMailSystem::_get_substring() should resolve that for any circumstances and negative side effects are not foreseeable. A patch to be submitted asap.

CommentFileSizeAuthor
#9 smtp-n2556369-9.patch365 byteswundo
#8 Screen shot 2016-01-30 at 10.45.10 PM.png34.39 KBAnonymous (not verified)
#5 smtp-n2556369-5.patch359 bytesdamienmckenna
#4 whitespace_in_header-2556369-4.patch439 bytesjurgenhaas
#2 whitespace_in_header-2556369-2.patch473 bytesjurgenhaas

Comments

jurgenhaas created an issue. See original summary.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Active » Needs review
StatusFileSize
new whitespace_in_header-2556369-2.patch473 bytes

Status: Needs review » Needs work

The last submitted patch, 2: whitespace_in_header-2556369-2.patch, failed testing.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Needs work » Needs review
StatusFileSize
new whitespace_in_header-2556369-4.patch439 bytes

A sorry, just forgot that PHPStorm is still generating non-compatible patch files. Manually edited the file and it should now be OK.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new smtp-n2556369-5.patch359 bytes

Rerolled.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2651788: Plan for SMTP 7.x-1.4 release

This would be safe to include in the next release.

Anonymous’s picture

Anonymous (not verified) commented

Qued for retest.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new Screen shot 2016-01-30 at 10.45.10 PM.png34.39 KB

Works great for me. Terminal image included.

wundo’s picture

wundo commented
StatusFileSize
new smtp-n2556369-9.patch365 bytes

Patch needed re-roll, here is the updated file

  • wundo committed 77754f6 on 7.x-1.x 
    Issue #2556369 by jurgenhaas, DamienMcKenna, wundo: Whitespace in header...
wundo’s picture

wundo commented
Status: Needs review » Fixed

  • wundo committed 77754f6 on 7.x-2.x 
    Issue #2556369 by jurgenhaas, DamienMcKenna, wundo: Whitespace in header...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.