Remove unused variables:

/smtp.phpmailer.inc
Unused variable $key.
Unused variable $tmp.

/smtp.mail.inc
Unused variable $id.

CommentFileSizeAuthor
#7 smtp-n2548133-7.patch2.02 KBdamienmckenna
#2 Removed-unused-variables-2548133-1.patch1.67 KBrrfegade

Comments

rrfegade created an issue. See original summary.

rrfegade’s picture

rrfegade commented
StatusFileSize
new Removed-unused-variables-2548133-1.patch1.67 KB

pfa the patch

rrfegade’s picture

rrfegade commented
Status: Active » Needs review
wundo’s picture

wundo commented

What did you use to generate those patchs?

rrfegade’s picture

rrfegade commented

patch is created manually

wundo queued 2: Removed-unused-variables-2548133-1.patch for re-testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new smtp-n2548133-7.patch2.02 KB

Rerolled.

Status: Needs review » Needs work

The last submitted patch, 7: smtp-n2548133-7.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: rrfegade » Unassigned
wundo’s picture

wundo commented
wundo’s picture

wundo commented
Status: Needs review » Fixed

  • wundo committed 2a72142 on 7.x-1.x authored by DamienMcKenna 
    Issue #2548133 by rrfegade, DamienMcKenna, wundo: Remove unused varibles...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.