Since this module is setting $_SESSION data for anonymous users, it makes caching with Pressflow and Varnish impossible. Related is #1310426: PHP 5.3.x E' Notices: Undefined property: stdClass::$profile_smart_tabs_disable, but the fix there is just to fix a notice. I'd like to see this module have an option to disable this behavior for anonymous users. Patch forthcoming.

CommentFileSizeAuthor
#1 smart_menus-smart-tabs-no-anonymous-sessions-1800522-01.patch722 bytesjhedstrom

Comments

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Active » Needs review
StatusFileSize
new smart_menus-smart-tabs-no-anonymous-sessions-1800522-01.patch722 bytes

This patch adds a variable to disable smart tabs for anonymous users. The default is the current behavior, so existing sites will not be impacted.

rdeboer’s picture

rdeboer
Location Melbourne
commented

Thanks Jonathon!,
You are right. Hope to apply this soon.

By the way, I've just released a module to deal with this issue in a wider sense: Session Cache API.

Rik

rdeboer’s picture

rdeboer
Location Melbourne
commented

Patch applied.
Thanks Jonathon!
Rik

rdeboer’s picture

rdeboer
Location Melbourne
commented
Assigned: Unassigned » rdeboer
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.