The work in #3137724: error after updating fullcalendar allowed Smart Date to support the new data structure implemented by Fullcalendar View in #3060026: Support Multiple Calendars in One View. Unfortunately, that fix broke Smart Date's compatibility with older versions of Fullcalendar View. It would be better if the code was able to work with either version.

CommentFileSizeAuthor
#3 smart_date-support_old_and_new_fcv-3145989-3.patch2.27 KBmandclu
#2 smart-dates-hidden.png81.51 KBkkaya

Comments

mandclu created an issue. See original summary.

kkaya’s picture

kkaya commented
StatusFileSize
new smart-dates-hidden.png81.51 KB

Thanks - when I use Smart Date 8.x-2.7 and FCV 5.0.0, I don't see the events displayed correctly until I resize my browser. For example, the following screenshot is how an event for June 5, 2020 looks when I load the calendar view:

https://www.drupal.org/files/issues/2020-06-04/smart-dates-hidden_0.png

Once the page is loaded and I adjust the width of my browser window, the event appears.

mandclu’s picture

mandclu commented
StatusFileSize
new smart_date-support_old_and_new_fcv-3145989-3.patch2.27 KB

Please test the attached patch, especially with older versions of FCV (8.x-4.2 or below).

mandclu’s picture

mandclu commented

@kkaya Oh and please open a new issue for the display bug. Have you verified that it only happens with Smart Date values and not core or FCV dates?

kkaya’s picture

kkaya commented

Thanks again @mandclu. Good point - it appears with core dates too. It looks like a theme issue.

mandclu’s picture

mandclu commented

I opened up #3146001: Calendar is squished on initial load because it seems like something that needs to be fixed in Fullcalendar View. If you have any additional observations, please add them there.

mandclu’s picture

mandclu commented
Status: Active » Needs review
jon.lund’s picture

jon.lund commented

I can verify that this happens to me also. In Both Drupal 8 || 9

mandclu’s picture

mandclu commented

@jon.lund there have been a couple of issues discussed here, can you clarify which you're experiencing? Which versions of Smart Date and Fullcalendar View are you using?

If you are experiencing the original issue, did the patch help?

jon.lund’s picture

jon.lund commented

Core 9.0.0 Smart Date 8.x-2.7 and Fullcalendar 5.0.2
Core 8.8 Smart Date 8.x-2.7 and Fullcalendar 5.0.1

Both Smart Dates and Fullcalendar are working as designed after applying the patch, other than when first opening the calendar the days are "squished". Move forward a month and things look better. Move back to the original month and things still look great. The "squished" behavior is only on opening.

I should have been more clear. Again, thank you for all your work.

Edit: Further testing in Core 9.0.0 with the theme.

  • Using Bootstrap 8.x-3.22 All calendars render beautifully.
  • Using Bartik the calendar exhibits the above mentioned behavior.
mandclu’s picture

mandclu commented

Hmmm so for updates regarding the calendar being squished on initial load, those should really be tracked in #3146001: Calendar is squished on initial load. That said, the fix there should be in both 5.0.1 and 5.0.2, so it's surprising that you're still seeing the problem, given the versions you're using.

Have you tried doing a hard reset on your browser cache? I know sometimes the browser likes to hold onto old versions of Javascript files, and the fix in question was adding a single line of JS.

mandclu’s picture

mandclu commented
Status: Needs review » Closed (outdated)

There have been numerous releases of both modules since this was worked on, so closing as outdated. Feel free to reopen if there is still work to do.