Closed (fixed)
Project:
Smart Date
Version:
8.x-2.5
Component:
Code
Priority:
Major
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
19 May 2020 at 04:26 UTC
Updated:
18 Jun 2020 at 21:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mandclu commentedI'm not having any luck reproducing this issue. Here's what I tried:
I also checked the Smart Date codebase and validateUtf8() isn't called anywhere, at least not directly. Is there some additional information you can provide on how to reproduce your error?
Comment #3
jon.lund commentedI can confirm the behavior. The Events view with pages for the Past and Upcoming events work. The Events Calendar no longer displays the items.
I removed (deleted) the Events View, Events Calendar View, and the Event Content type.
Then Installed the Smart Date Starter Kit and the Smart Date Calendar Kit.
Added Content to the Event content type.
Results:
The same behavior.
Events View displays as designed.
Events Calendar View does not display node content.
There are no errors displayed.
Comment #4
mandclu commentedOK, I can confirm this issue with the 8.x-4.3 release of Fullcalendar View. Probably need to update our FullcalendarViewProcessor based on the changes in #3060026: Support Multiple Calendars in One View.
Comment #5
mandclu commentedThe changes in the attached patch seem to get the calendar working again for me.
Comment #6
jon.lund commentedThis patch seems to work for me.
Note: be sure to Clear Cache.
Thank you!
Comment #8
mandclu commentedThanks for testing, merged in these changes. It's unfortunate that a minor version update for FCV broke this, because now this update will break the FCV display for anyone using a version <8.x-4.3. Still, hope to have a new release available shortly.
Comment #9
sean.flaherty commentedHi, I have tested and verified that this patch fixes full calendar integration.
Please consider releasing a minor release or at least putting a visible notice until then that this is currently broken out of the box, was slightly frustrating, although I understand it was an upstream issue.
Thank you, I really appreciate this module, very well done!
Comment #10
mandclu commentedThanks for the reminder. It's been on my todo lists, just under a tight deadline. Will try to get out a new release today.
Comment #11
michaelschutz commentedI've had a few issues with the most recent versions of Smart Date and FCV. Unfortunately it seems like Mingsong isn't all that interested in making it easy to work together on this (e.g. see his comments in https://www.drupal.org/project/fullcalendar_view/issues/3143986), so I'm not even sure that I should be asking for mandclu to make extra efforts to continue to integrate. It's the best solution I've found, but unfortunately it seems to be getting worse with each release of FCV. :(
I've updated 2 sites to Smart Date 2.6 and FCV 4.5 (I didn't patch as per this thread, since I think it was incorporated into 2.6). Now, on both sites, the events are shown in their proper places in the calendar, and they show the proper time. But every event has the same title - the title of one of the events that exists. I can't tell why or how this is happening, but I've confirmed it's not just unique to one site.
Settings:
Once again, any help is appreciated.
Comment #12
mandclu commented@michaelschultz I can't reproduce the problem you're describing. I have a recurring event and a single instance one, and each appears to display the appropriate title. Can you offer any additional steps to reproduce the problem?
Comment #13
michaelschutz commentedThanks @mandclu - they're both on sites where I upgraded both Smart Date and FCV to latest versions. On the one site, I had it working with patches on older versions, then I updated (I think to Smart Date 2.4 and FCV 4.3) and all my dates disappeared. Updating again to 2.6 and 4.5 brought them back, but with this problem.
Being that this isn't easily reproducible by you, I'll check it out further. I'm wondering if I have old patches still applied somehow. I'll start by manually replacing the codebase of both modules on my test site to ensure I don't have old code mixed in with the new versions.
Comment #14
mandclu commentedComment #15
mandclu commentedSounds good. If you do find a problem, it might be best to open a new issue.