In my styling I have backgrounds for caption and title. If there is no content for either content or title, the span wrappers are still outputted, which doesn't look great in a use case were some of your slideshows are empty, and you have styled backgrounds with padding.

I tried putting the spans inside the if loop on line 525 of slideshow_creator.inc but that broke the slideshow. Instead I removed them with 1 line of js. Here's a patch against 7.x-1.x

Comments

rhouse’s picture

Status: Patch (to be ported) » Fixed
StatusFileSize
new898 bytes
new894 bytes

Nice work spotting that blemish! I think your original instinct was correct, the problem must be fixed in the php rather than papered over later. The attached patch (D6 and D7 versions) corrects slideshow_creator.inc and has been committed to the git repository.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.