The settings for the views style plugin are being set using the default values each time. I'll attach a simple patch to fix this issue.

CommentFileSizeAuthor
#1 slick_views-style-options_2303203-1.patch1.04 KBscottalan

Comments

scottalan’s picture

scottalan commented
StatusFileSize
new slick_views-style-options_2303203-1.patch1.04 KB
scottalan’s picture

scottalan commented

I'm actually looking into 7.x-2.x. The above patch should actually be (I think):

'#default_value' => isset($this->options['slick_settings'][$name]) ? $this->options['slick_settings'][$name] : $options[$name]['default'],

I have 2.x checked out right now but will get a new patch when I can.

Will probably need to debug again just to be sure...

2.x looks awesome, can't wait to dig into it. I'll help where I can.

scottalan’s picture

scottalan commented

It looks like in 7.x-2x the default_value is correct. This just applies to 7.x-1.x

esolitos’s picture

esolitos
he/him
Primary language Italian
Location Trondheim
commented

I'm using 7.x-1x -dev i can confirm the issue and the fix.
I changed a little bit the patch, but the idea is the same.

diff --git a/theme/slick.theme.inc b/theme/slick.theme.inc
index a49b179..6d7d769 100644
--- a/theme/slick.theme.inc
+++ b/theme/slick.theme.inc
@@ -11,7 +11,7 @@
 function template_preprocess_slick(&$variables) {
-  $options = $variables['options'];
+  $options = $variables['options']['slick_settings'];
   $slick_options = slick_get_options();
   $settings = array_intersect_key($options, $slick_options);
 
   // Add libraries.
   drupal_add_library('slick', 'slick');
esolitos’s picture

esolitos
he/him
Primary language Italian
Location Trondheim
commented
Status: Active » Patch (to be ported)
alit’s picture

alit commented

Thanks, scottalan. The patch #1 solves the problem for me.

esolitos’s picture

esolitos
he/him
Primary language Italian
Location Trondheim
commented
Priority: Normal » Major
Status: Patch (to be ported) » Reviewed & tested by the community

I did set the wrong status last time.

  • gausarts committed 626fbea on 7.x-1.x authored by scottalan 
    Issue #2303203 by scottalan: Fixed Views style plugin - settings using...
gausarts’s picture

gausarts commented

Thanks you all. Sorry for delay, and wrong issue number in the previous commit.

gausarts’s picture

gausarts commented
Status: Reviewed & tested by the community » Fixed

Feel free to reopen if still an issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.