Closed (fixed)
Project:
Slashcomments
Version:
6.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Nov 2011 at 00:13 UTC
Updated:
9 Dec 2011 at 21:40 UTC
With the dev version of the module, the comment formatting is not working properly. 'Display: Threaded' works okay till 3 comments-on-comments. From the fourth one they get aligned in a line.
Also rating names are not translated in this module. With the stable version, translation worked well.
Comments
Comment #1
Mirthis commentedHi sanhitamj and thanks for your feedback.
Is like that by design. It was introduced for a specific need and I've almost forgotten about it. I'll see how to make it configurable.
Having the ratings configurable makes pretty hard to keep the translations. If you don't have a multi-language site you can simply override the values from the settings page.
Andrea
Comment #2
Mirthis commentedHey sanhitamj,
As soon as the commit I've just made got published the 'issue' with thread indentation should disappear. That was achieved through CSS so it made no sense to keep it in the code.
Andrea
Comment #3
sanhitamj commentedThis might be a silly comment.
But I don't understand this.
Do you mean that I should change something in the CSS file for comment indentation on the thread?
Is this part of the code relevant for indentation:
// Commnet flat and trheaded display
define('SLASHCOMMENTS_MODE_FLAT', 2);
define('SLASHCOMMENTS_MODE_THREADED', 4);
Comment #4
Mirthis commentedSorry, I didn't want to create confusion.
What I was saying is that the level of indentation can be easily controlled through css and it doesn't belong to the module in the first place, so I've removed from the stylesheet the lines that made that happens and if you download the latest dev release it should work as expected (infinite indentation).
Andrea
Comment #5
sanhitamj commentedYes, that works fine. Thanks a ton.
Comment #6
Mirthis commented