With the dev version of the module, the comment formatting is not working properly. 'Display: Threaded' works okay till 3 comments-on-comments. From the fourth one they get aligned in a line.

Also rating names are not translated in this module. With the stable version, translation worked well.

Comments

Mirthis’s picture

Hi sanhitamj and thanks for your feedback.

With the dev version of the module, the comment formatting is not working properly. 'Display: Threaded' works okay till 3 comments-on-comments. From the fourth one they get aligned in a line.

Is like that by design. It was introduced for a specific need and I've almost forgotten about it. I'll see how to make it configurable.

Also rating names are not translated in this module. With the stable version, translation worked well.

Having the ratings configurable makes pretty hard to keep the translations. If you don't have a multi-language site you can simply override the values from the settings page.

Andrea

Mirthis’s picture

Hey sanhitamj,
As soon as the commit I've just made got published the 'issue' with thread indentation should disappear. That was achieved through CSS so it made no sense to keep it in the code.

Andrea

sanhitamj’s picture

This might be a silly comment.

As soon as the commit I've just made got published the 'issue' with thread indentation should disappear. That was achieved through CSS so it made no sense to keep it in the code.

But I don't understand this.

Do you mean that I should change something in the CSS file for comment indentation on the thread?

Is this part of the code relevant for indentation:
// Commnet flat and trheaded display
define('SLASHCOMMENTS_MODE_FLAT', 2);
define('SLASHCOMMENTS_MODE_THREADED', 4);

Mirthis’s picture

Sorry, I didn't want to create confusion.
What I was saying is that the level of indentation can be easily controlled through css and it doesn't belong to the module in the first place, so I've removed from the stylesheet the lines that made that happens and if you download the latest dev release it should work as expected (infinite indentation).

Andrea

sanhitamj’s picture

Yes, that works fine. Thanks a ton.

Mirthis’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.