Custom.css not included with private download

Hi,

It's just the link generated that's not correct (so more a code problem). The css is generated correctly at the place where it should. It's however not included properly. Maybe it's an idea to use/geneate a php script that emits the css with proper mime type (see the following firefox observation below).

One thing though that gives problems (accoriding to my notes) is that firefox has problems with a wrong mimetype when the file is located at files/sky.

Here is my version of the code & comments (note it tests for generated version but uses a manual copy):

$custom_css gets a value of 'c:/wamp/files/sky/custom.css' which becomes something like
http:///drupal/c:/wamp/files/sky/custom.css when used in an hyperlink. And that is an invalid link causing it not to be doenloaded & included as it should.

// Theme Settings Generated CSS
//veg: Disabled because it does not include properly, moved code to _sky_conditional_stylesheets() below
//veg: Downloading from /files/sky gives a wrong mime type -> firefox problems.
//veg: Note we still check for the default location, but we need a copy in the themes css directory.
$custom_css = file_directory_path() .'/sky/custom.css';
if (file_exists($custom_css)) {
  drupal_add_css(path_to_theme() .'/css/custom.css', 'theme', 'all', TRUE);
//drupal_add_css($custom_css, 'theme', 'all', TRUE);
}

Hi,

I have got a solution for the problem.

1) In Template.php only use drupal_add_css for public downloads (drupal_add_css fails for private stylesheets).

//veg: 02-02-2009 - Default code only when Public Downloads.
$custom_css = file_directory_path() .'/sky/custom.css';
if (file_exists($custom_css)) {
  if (variable_get('file_downloads', NULL) == FILE_DOWNLOADS_PUBLIC) {
		drupal_add_css($custom_css, 'theme', 'all', TRUE);
  }
}

2) Extend the function _sky_conditional_stylesheets() a bit so it adds the stylesheet after the conditional ones if the download method is private:

// Conditional stylesheets for IE
function _sky_conditional_stylesheets() {
  $output = "\n".'<!--[if IE 6.0]><link rel="stylesheet" href="'. base_path() . path_to_theme() .'/css/ie-6.css" type="text/css" media="all" charset="utf-8" /><![endif]-->'."\n";
  $output .= '<!--[if IE 7.0]><link rel="stylesheet" href="'. base_path() . path_to_theme() .'/css/ie-7.css" type="text/css" media="all" charset="utf-8" /><![endif]-->'."\n";

//veg: 02-02-2009 - hardcoded link when Private Downloads.
//                  NOTE: it needs the sky module to fix the mimetype for FireFox 
//								        when downloading from base_path()./system/files/sky/custom.css. 
//	                      Drupal sends a mime-type application/x-download which FireFox ignores.

	$custom_css = file_directory_path() .'/sky/custom.css';
	if (file_exists($custom_css)) {
		if (variable_get('file_downloads', NULL) == FILE_DOWNLOADS_PRIVATE) {
			$custom_css = base_path() .'system/files/sky/custom.css';
			//outputdebugstring($custom_css,"sky (private)");
			$output .= "\n".'<link type="text/css" rel="stylesheet" media="all" href="'.$custom_css.'" />'."\n";
		}
	}
	
  return $output;
}

3) Now the funny part. When drupal serves a file from base_path().'/system/files' it always seems to use a mimetype of 'application/x-download' unless a module overrides it in a hook_file_download().

This is where FireFox stumbles (IE and others just homour the mime type supllied in the html, FireFox looks to the actual download too and then just refuses it).

Baseline I wrote a very small sky module that supplies the correct mime type when downloading the custom.css file if the download methods is set to private.

Sky.info:

; $Id: sky.info,v 1.5 2008/10/03 03:44:07 wvd_vegt Exp $
name = Sky
description = Sky theme helper.
core = 6.x

; Information added by drupal.org packaging script on 2007-09-29
version = "6.x"
project = "sky"
datestamp = "1193629803"

Sky.install:

<?php

// $Id: sky.install,v 1.5 2008/10/03 03:44:07 wvd_vegt Exp $

/**
 * @file
 * Sky theme helper.
 */
function sky_select_types_install() {  
}

sky.module:

<?php

// $Id: sky.module, v 1.5 2008/10/03 03:44:07 wvd_vegt Exp $

/**
 * @file
 * Sky theme helper.
 *
 * Fixes the mimetype for custom.css if the download method is set to private. 
 * Only FireFox seems to be affected (and refuses to download with the default.
 * application/x-download that Drupal supplies.
 *
 * veg:02-02-2009 - Created.
 */

/**
 * Implementation of hook_file_download(). 
 */
function sky_file_download($filepath) {
  if ($filepath=="sky/custom.css" && 
      variable_get('file_downloads', NULL) == FILE_DOWNLOADS_PRIVATE) {
    return 'Content-Type: text/css; authoritative=true';
  }
}

So basically for sites with a public download method nothing changes. For private download the location of the custom.css include changes a bit and for FireFox a small module needs to be installed and activated.

As far as i can see the only thing not 100% correct is that if the cache is cleared, the custom.css is not forces to be re-downloaded (by appending random query suffix).

Hi,

Off-course I do agree with both previous posts, I just added the module for those wanting a fix now (even though it's clumsy and should be fixed in the Drupal core).

We use the module with some FireFox users (including our boss) with private upload method and variable width (so a very special case).

So it should not be considered a patch but merely a want to get it working until it's properly fixed in the core (and only if you have this kind of setup). It took me a while to figure out whats causing it and documenting it in a fix is perhaps the best way.

Btw for those using it, you should change the name as a module and a theme with the same name is someting Drupal doesn't like (I know named it sky_fix).

Maybe promoting it as a separate module isn't a bad idea so you can fix certain mime types causing problems.