I've run Drupal checker, as result there is still deprecated code in 8.x-1.x.dev branch.

Line sitemap.module
------ -------------------------------------------------------------------------
224 Call to deprecated function db_select():
in drupal:8.0.0 and is removed from drupal:9.0.0. Instead, get
a database connection injected into your service from the container and
call select() on it. For example,
------ -------------------------------------------------------------------------

------ --------------------------------------------------------------------------
Line sitemap.theme.inc
------ --------------------------------------------------------------------------
164 Call to deprecated method entityManager() of class Drupal:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
------ --------------------------------------------------------------------------

------ -------------------------------------------------------------------
Line src/Form/SitemapSettingsForm.php
------ -------------------------------------------------------------------
89 Call to deprecated method l() of class Drupal\Core\Form\FormBase:
in drupal:8.0.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\Link::fromTextAndUrl() instead.
264 Call to deprecated method l() of class Drupal\Core\Form\FormBase:
in drupal:8.0.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\Link::fromTextAndUrl() instead.
------ -------------------------------------------------------------------

------ ----------------------------------------------------------------------------------------------------
Line src/Tests/SitemapBookTest.php
------ ----------------------------------------------------------------------------------------------------
12 Class Drupal\sitemap\Tests\SitemapBookTest extends deprecated class Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
32 Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
------ ----------------------------------------------------------------------------------------------------

------ -------------------------------------------------------------------------------------------------------
Line src/Tests/SitemapContentTest.php
------ -------------------------------------------------------------------------------------------------------
13 Class Drupal\sitemap\Tests\SitemapContentTest extends deprecated class Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
26 Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
------ -------------------------------------------------------------------------------------------------------

------ ---------------------------------------------------------------------------------------------------
Line src/Tests/SitemapCssTest.php
------ ---------------------------------------------------------------------------------------------------
12 Class Drupal\sitemap\Tests\SitemapCssTest extends deprecated class Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
25 Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
------ ---------------------------------------------------------------------------------------------------

------ --------------------------------------------------------------------------------------------------------
Line src/Tests/SitemapMenuTestBase.php
------ --------------------------------------------------------------------------------------------------------
10 Class Drupal\sitemap\Tests\SitemapMenuTestBase extends deprecated class Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
37 Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
------ --------------------------------------------------------------------------------------------------------

------ ---------------------------------------------------------------------------------------------------
Line src/Tests/SitemapRssTest.php
------ ---------------------------------------------------------------------------------------------------
13 Class Drupal\sitemap\Tests\SitemapRssTest extends deprecated class Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
26 Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
45 Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_strtolower() instead.
------ ---------------------------------------------------------------------------------------------------

------ ---------------------------------------------------------------------------------------------------------------------
Line src/Tests/SitemapTaxonomyTestBase.php
------ ---------------------------------------------------------------------------------------------------------------------
13 Class Drupal\sitemap\Tests\SitemapTaxonomyTestBase extends deprecated class Drupal\taxonomy\Tests\TaxonomyTestBase:
in drupal:8.?.? and is removed from drupal:9.0.0.
Use \Drupal\Tests\taxonomy\Functional\TaxonomyTestBase instead.
47 Call to method setUp() of deprecated class Drupal\taxonomy\Tests\TaxonomyTestBase:
in drupal:8.?.? and is removed from drupal:9.0.0.
Use \Drupal\Tests\taxonomy\Functional\TaxonomyTestBase instead.

CommentFileSizeAuthor
#8 3180990-8.patch25.59 KBsaphemmy
#5 3180990-3.patch8.41 KBmiiimooo
#2 3180990-2.patch6.64 KBsdstyles

Issue fork sitemap-3180990

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

sdstyles created an issue. See original summary.

sdstyles’s picture

Status: Active » Needs review
StatusFileSize
new6.64 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3180990-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

ikit-claw made their first commit to this issue’s fork.

miiimooo’s picture

Status: Needs work » Needs review
StatusFileSize
new8.41 KB

I've added some fixes for the SitemapSettingsForm as it was giving me PHP warnings in \Drupal\Component\Utility\Html::escape

Otherwise this patch works for me in Drupal 9

Status: Needs review » Needs work

The last submitted patch, 5: 3180990-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

kristen pol’s picture

Issue tags: +Drupal 9 compatibility

This may be duplicate as the module is already D9 compatible but I haven't looked at the details.

saphemmy’s picture

StatusFileSize
new25.59 KB

The first and major points on this issue have been made resolved as the codebase is fixed(D9 Compatible) as stated by Kristen Pol's

Meanwhile, I reviewed deprecated codes, removed and updated them within sitemap.theme.inc and many other files to conform with D9 coding standards.

akalata’s picture

Status: Needs work » Closed (won't fix)

Closing, as 8.x-1.x did not support D9 and D8 is no longer supported.