I found a few issues with the permissions used by this module.

Firstly, the 'simplify node hide settings' permission was not intuitive. It's hard to know what it means so should be re-named.

Secondly, let's say I wanted to apply the Simplify settings to all users except the Administrator. There's no way to do this because checking the box for 'Authenticated' in Drupal 7 also applies that permission to all other roles (such as 'Administrator'). I think this needs to be reversed (i.e. have a permission to override Simplify's settings, so that all users see the simplified interface except those selected).

CommentFileSizeAuthor
#1 better_permissions-1170274-1.patch1.73 KBAnonymous (not verified)

Comments

Anonymous’s picture

Status: Active » Needs review
StatusFileSize
new1.73 KB

Here's a patch that addresses the above issues.

Anonymous’s picture

Status: Needs review » Closed (duplicate)

The patch at #1145724: Allow Simplify for Specific Content Type... includes these changes, so marking this as a duplicate.

Vasu’s picture

Version: 7.x-1.1 » 7.x-2.1
Status: Closed (duplicate) » Active

Well the issue is still present. Probably we need to give permission to specific roles like 'administrator' (not user 1) to override 'simplify' settings. A similar function exists in http://drupal.org/project/jammer, it is not as simple as this module but the 'permissions' are more intuitive and practical.

markshust’s picture

I do not want to change any existing variables as it will bomb out installs already using this module. Vasu's recommendation sounds like a better idea but I'd need to see a good way of doing this to apply this update.

markshust’s picture

Category: task » feature
Anonymous’s picture

I do not want to change any existing variables as it will bomb out installs already using this module.

It wouldn't be too hard to release these changes in a new version (7.x-2.2) that includes some PHP in the update function that changes the old variables to the new would it?

Anonymous’s picture

Version: 7.x-2.1 » 7.x-3.x-dev

A better permissions system will go in the new 3.x branch.

Anonymous’s picture

Status: Active » Fixed

Better permissions have been added as a part of this commit: http://drupalcode.org/project/simplify.git/commit/7f7f1c6

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.