Multiple upgrade bugfixes for simpletest

Same again. I have installed 2.5 than checked the status page that shows me there are database upgrades (why ever - this shouldn't be the case, too). Executing this upgrades end with the following:

The following queries were executed
simpletest module
Update #6000

    * Failed: DROP TABLE {simpletest_test_id}
    * CREATE TABLE {simpletest_test_id} ( `test_id` INT NOT NULL auto_increment, PRIMARY KEY (test_id) ) /*!40100 DEFAULT CHARACTER SET UTF8 */

Update #6001

    * Failed: ALTER TABLE {simpletest} DROP message
    * Failed: ALTER TABLE {simpletest} ADD `message` TEXT DEFAULT NULL
    * Failed: ALTER TABLE {simpletest} CHANGE message `message` TEXT NOT NULL

Update #6002

    * Failed: ALTER TABLE {simpletest} DROP caller
    * Failed: ALTER TABLE {simpletest} ADD `function` VARCHAR(255) NOT NULL DEFAULT ''

I tried this now... and the schema is now created correctly, but nevertheless simpletest doesn't work.

Aside - do you really think that hacking the system table is user friendly? You should spend some resonable time on an upgrade path!

Sorry, but don't you think that you should add an upgrade function as all other modules also do? Maybe with upgrade number 6000 that installs the schema because hook_install is not executed again? This would be a clean upgrade. You shouldn't leave the people alone with this heavy task. Editing system tables is out of scope for beginners and hacking core tables is also often out of scope for non-core developers and don't forget that others install this module to use it - not to review it first and waste 2 days in analysing why it is broken!

Add a clean upgrade path, please.

Patch attached, but not yet tested. I will test this later the day and report back.

Reworked patch as I've found much more bugs then the missing schema install bug only. This patch has been tested with 6.x-1.2 to 6.x-2.5 and the upgrade now works as expected and required. I have analysed all releases since 2.1 to figure out all upgrade bugs and to fix them. Schema module now reports that all existing tables match the schema.

Bugs fixed:
1. Allows simpletest upgrade from 6.x-1.2 to 6.x-2.x.
2. Generates binary and text test files on upgrade.
3. Uninstall removes binary and text test files.
4. Translatable string fixes. (Line breaks are not allowed.)
5. A few other minor code style issues have been fixed.

Added - Drop table to make sure field 'test_id' and primary key is fixed (6.x-2.1 bug fixed in 6.x-2.2). Nevertheless 2.1 people cannot get into this update hook as they already have schema version 7000. This is a nobrainer to me - maybe better go with #8 patch only. This patch haven't been re-tested by me.

Sorry, but what do you mean? The uninstall part? It's a must for D6 and D7 - not only D7. If I uninstall a module I expect that my machine get cleaned up and reverted to pre-simpletest installation. As more I'm thinking about this - the "Clean environment" of stale simpeltest data must also been executed on uninstall. This is currently missing in my patch.

We should add:

simpletest_clean_database();
simpletest_clean_temporary_directories();

or

simpletest_clean_environment();

But this could become an extra case.