module_list is being called incorrectly in drupal_unit_tests [#153402]

I think, but am not sure, that the module_list method is being called incorrectly in drupal_unit_tests.php. It's being called:

module_list(TRUE)

But I think it should be:

module_list(TRUE, FALSE)

bootstrap is the second parameter (which is TRUE by default). This resets the module list to just a minimal list of modules. This is causing some problems when trying to interface with the code. drupal_test_case.php also calls module_list, but calls it setting the bootstrap parameter to FALSE.

Comment	File	Size	Author
#3	simpeltest_modulelist.patch	2.52 KB	Rok Žlender
#1	drupal_unit_testsmodulerefresh.patch	1.92 KB	Rok Žlender

Comments

Comment #1

Rok Žlender commented 7 July 2007 at 09:33

Status	File	Size
new	drupal_unit_testsmodulerefresh.patch	1.92 KB

I looked into it. drupalModuleEnable function in drupal_unit_tests is rarely used thats why it hasnt been updated. Attached patch fixes modleEnable function and it is now equal to moduleEnable function in drupal_test_case.

If you can test it and let me know if it fixes your problems.

Comment #2

hadsie commented 19 July 2007 at 18:18

Hey Rok,

After some testing your patch appears to be working just fine.

Comment #3

Rok Žlender commented 21 July 2007 at 08:48

Status:

Active

» Needs review

Status	File	Size
new	simpeltest_modulelist.patch	2.52 KB

After a bit of research I noticed that module_list is not necessary when you call module_enable because thats already done. So now I removed call to module_list where we enable modules with module_enable.