It clarifies user interface, makes it more intuitive, because we don't have to set setting that our configuration does not use.

CommentFileSizeAuthor
#5 simplenews-minor_admin_ui_improvement-1787574-5.patch1.89 KBPatchRanger
#1 minor_admin_ui_improvement-1787574-1.patch1.88 KBPatchRanger

Comments

PatchRanger’s picture

PatchRanger commented
Status: Active » Needs review
StatusFileSize
new minor_admin_ui_improvement-1787574-1.patch1.88 KB

Please review the patch.
I think it makes sense.

Status: Needs review » Needs work

The last submitted patch, minor_admin_ui_improvement-1787574-1.patch, failed testing.

PatchRanger’s picture

PatchRanger commented
Status: Needs work » Needs review

#1: minor_admin_ui_improvement-1787574-1.patch queued for re-testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs review » Patch (to be ported)

This makes sense but is strictly speaking an API change (someone might alter the form and do something with it) so I'm not sure about comitting it against 7.x-1.x. Happy to commit it to 7.x-2.x, but it will need a re-roll for that.

PatchRanger’s picture

PatchRanger commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new simplenews-minor_admin_ui_improvement-1787574-5.patch1.89 KB

@Berdir No problem at all. Re-rolled against the latest 7.x-2.x.
Please review.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks, commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.