Unsubscribe link in Simplenews footer is http://default when cron run from drush without --uri parameter

How are these files being generated? Through a normal Drupal page request or via the command line (e.g. during a cron run)?

This typically happens when using drush or other CLI tools that don't pass a $_SERVER['HTTP_HOST'] option, which you can correct by passing a --url value in the command.

Yes this is a known issue.
Basically it possibly lacks documentation.

In my opinion, this is a bug of drush or even drupal core.
"default" or "localhost" is just NO reasonable default. Instead the system should apply its known base URL.
Note that with multisites this is not really clear... So if you check the drush documentation, it states:
"URI of the drupal site to use (only needed in multisite environments)"
This means, drush can not provide any reasonable default for these cases...

I'm happy if you can help us improving the documentation.
Also i suggested to the drush team once to completely ban drush executions without uri parameter in case of multisites.
Also we considered stopping cron excution if w detect cases such as "default" or "localhost".

But basically no one feels responsible for such a messy result.
What i can say for sure is: Simplenews is the wrong place to fix it. We just could detect the failure and avoid sending out spam.

Well, specific to this issue, DA does require a URL parameter, because you may wish to send newsletters from specific domains.

I think this is a documentation issue (possibly for Drush), but its covered in the DA docs (and cron) as well.

Any cron implementation is supposed to pass a valid URL request. See http://drupal.org/cron

@babbage

And, specific to DA, if you need to send newsletters from various domains, you may need an implementation of hook_domain_cron() as well. See the DA API file.

Patches welcome.

If you set the base url in settings.php then cron will use that value.

It's not the right solution, but it is a workaround.

I didn't test it recently, but setting a base url in settings.php did NOT affect any drush (cron) call.

See also related task
#2396121: Stop sending via cron without meaningful hostname

any update on this? its still happening on all my different drupal installs!
can anyone help with this?
what if someone does NOT have drush. they simple go to contents > newsletter and push send newsletter (in simplenews, its selected to use cron to send newsletter 200 at a time and cron runs every 3 hours)
any help will be greatly appreciated.

I also reproduced the error.

@ariban99 If you click it in the UI through the browser, the link will point to the current URL domain or the base URL configured.
This really only is a drush issue.

For Drupal 8, we solved this:

function simplenews_cron() {
  if (!simplenews_assert_uri()) {
    return;
  }

function simplenews_assert_uri() {
  $host = \Drupal::request()->getHost();
  // Check if the host name is configured.
  if ($host == 'default') {
    \Drupal::logger('simplenews')->error('Stop sending newsletter to avoid broken links / SPAM. Site URI not specified.');
    return FALSE;
  }
  return TRUE;
}

Backports welcome.