Drupal 8 version

Hi @ipo4ka704,

I didn't have plans to port this module to D8 because it is too far away :)

However, I think it's a good idea. I'm up to help you with advice and propose our collaboration scheme.

1) First of all, I'd suggest you creating a sandbox project and pulling code from 7.x-2.x branch into it.
2) Then you'd port 7th version to 8th. It is important to port the code without significant changes: no bug fixes, no new features.
3) Next I'd review your code and confirm that you followed coding standards and other best practices of Drupal development.
4) Then I would create 8th branch and pull your sandbox code into it.

Does this plan work for you?
Let me know if you need information about coding standards and contribution best practices.

Thanks,
Konstantin

Awesome. Thanks!
Feel free to ask me any questions. I'm available for you by email or skype. Just start our conversation by sending your skype ID through my drupal.org contact form.

Best,
Konstantin

@ipo4ka704 thank you for the sandbox project. I will review your changes when I have time.

About maintainership:

First of all, I don't have permissions to make you co-maintainers.

Anyway, you should understand the process of becoming a co-maintainer. You should show your willingness and ability to care about the project and its users. However, you have changed a couple of lines in the project and asking me to make you both co-maintainers.

Moreover, what are you both going to do in the project? We don't have any tasks. I personally think that it is not necessary right now. You may contribute by patches easily.

Thanks,
Konstantin

Here are my review results.

The patch:
1) The paths in the patch are not valid. See messages from log:

simplehtmldom>git apply --check update_d8-2220915-4.patch
error: simplehtmldom/helper.inc: No such file or directory
error: simplehtmldom/simplehtmldom.info: No such file or directory
error: simplehtmldom/simplehtmldom.install: No such file or directory

I've created 8.x-2.x branch for you https://drupal.org/node/561668/git-instructions/8.x-2.x
Please make patches for it.
2) The patch name doesn't follow the standards:
https://drupal.org/node/1054616

The sandbox project:
1) Your commit messages don't follow the standards:
https://drupal.org/node/52287
2) You added the redundant subfolder 'simplehtmldom' that's why your patch is invalid.

So I can say that you guys are not ready to become co-maintainers yet.

Thanks,
Konstantin

Also, please change status of the issue to 'Needs review' when you're ready for review.

Hi,
Konstantin

We have made patch for branch 8.x-2.x https://drupal.org/node/561668/git-instructions/8.x-2.x
Please test it.
Commits in sandbox project.

Hi @daylioti,

Thanks for your patch.

I'm afraid you have forgotten to change variable_get('install_profile', 'default').

-- Konstantin

Hi,
Konstantin

I'm forgot add to patch changes in helper.inc file.
Please test it.

Well, I've applied your patch but the module is not working.
Did you test it? If so, please provide your testing sequence.

What do you mean by testing? I tested the code that is found on the main page of your module https://drupal.org/project/simplehtmldom and everything works.
Perhaps you have not connected the library. It will have to connect manually, since through. Make a file to download it is not yet possible because that does not work drush in Drupal 8.

You're right, the patch is working. I've rechecked it and committed. Thank you for the contribution!

Drush 7 supports D8, by the way.

Best,
Konstantin

Also, created dev release https://drupal.org/node/2230453