The manual refresh is pointing to the vid instead of the nid which the refresh function now uses. Attached is a patch fixing the manual refresh link.

CommentFileSizeAuthor
refresh.patch749 bytesJHeffner

Comments

JHeffner’s picture

JHeffner commented
Status: Needs review » Closed (duplicate)

Sorry I didn't notice the dupe at http://drupal.org/node/146130 which discusses the fix.

JHeffner’s picture

JHeffner commented
Status: Closed (duplicate) » Needs review

Actually this isn't a dupe. I believe this was missed when converting from vid to nid.

m3avrck’s picture

m3avrck commented
Status: Needs review » Fixed

Thanks! That actually wouldn't fix the issue, it was a bit more wormy than that.

I refactored things, it is using $nid, and it's even slightly faster too.

See this commit: http://drupal.org/cvs?commit=100084

JHeffner’s picture

JHeffner commented

I ran your patch for about 1 week without problems and noticed some improvements in performance. However when I updated to the latest release lost the patch and it no longer applies against the current version.

m3avrck’s picture

m3avrck commented

Not sure what you mean, right now there is only one official 1.0 release. The new code for the 2.0 release is in CVS DRUPAL-5 branch.

JHeffner’s picture

JHeffner commented

Sorry, I meant to say off the latest dev branch which I actually run in production because of the overall improvements.

m3avrck’s picture

m3avrck commented

Ok so I'm still confused since this was fixed in the latest dev branch or you still have this problem?

JHeffner’s picture

JHeffner commented

I think I found the confusion. It appears that the simplefeed 5.x-1.x-dev package is being generated off HEAD and includes ver 1.46 of simplefeed.module that does not have these fixes. It also appears that Head is now tagged with Drupal6.

m3avrck’s picture

m3avrck commented

Yes, HEAD is not the version you want.

cvs update -dPr DRUPAL-5
cvs update -dPr DRUPAL-6--1

HEAD is junk :)

JHeffner’s picture

JHeffner commented

Yeah, I realized that in my last message when I was trying to figure out what happened. I grabbed the simplefeed 5.x-1.x-dev release that is being generated off HEAD using the update status module. I grabbed the DRUPAL-5 cvs version a few minutes ago and it looks good. You might want to update your release tag for simplefeed 5.x-1.x-dev in case someone else has problems. I also noticed it disappeared from your project page.

m3avrck’s picture

m3avrck commented

Ok thanks!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.