If someone sets up an ad for a future date, _simpleads_activate_deactive_ad() doesn't correctly de-publish the ad.

CommentFileSizeAuthor
#4 simpleads-de-publish_future_dates-2238745-3.patch889 bytesheddn
#1 simpleads-de-publish_future_dates-2238745-1.patch1.11 KBheddn

Comments

heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new simpleads-de-publish_future_dates-2238745-1.patch1.11 KB

Added a check for future dated ads.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: simpleads-de-publish_future_dates-2238745-1.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new simpleads-de-publish_future_dates-2238745-3.patch889 bytes

Facepalm.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs work » Needs review
yvesvanlaer’s picture

yvesvanlaer commented

4: simpleads-de-publish_future_dates-2238745-3.patch queued for re-testing.

minnur’s picture

minnur commented
Status: Needs review » Closed (won't fix)