Problem/Motivation

Access to the settings page (/admin/config/people/accounts/simple_pass_reset) is currently controlled by 'administer users' permission.
For all the websites I'm involved in which the client has access to manage their users, I don't want them to be able to alter Simple Pass Reset settings. So, a dedicated permission should be set.

Issue fork simple_pass_reset-3559254

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

phily created an issue. See original summary.

phily opened merge request !15

phily changed the visibility of the branch 3559254-give-the-settings to hidden.

phily opened merge request !16

phily’s picture

phily
he/him
Primary language French
Location 🇪🇺🇫🇷 Paris, France
commented
Status: Active » Needs review

MR16 ready for review.
With apologies for MR15 (commit bf4df7736e7851eb4802e1b730521469502a5c44) pushed to branch 8.x-1.x

joe huggans’s picture

joe huggans
Primary language English
Location Kiel, Germany
commented

Tested and works for me! someone might pull you on the permission name, I probably would go for 'administer simple password reset settings', rather than using the machine name of the module.

joe huggans’s picture

joe huggans
Primary language English
Location Kiel, Germany
commented

Double checked the permission name thing as I started doubting what I said, I think it's fine to use underscores in permission names it turns out so please ignore my comment on that - https://www.drupal.org/project/drupal/issues/2309869#comment-15093328

joe huggans’s picture

joe huggans
Primary language English
Location Kiel, Germany
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.