Problem/Motivation

Oauth2ScopePluginManagerLegacyTest is currently failing on 6.1.x because the strings passed to $this->expectDeprecation() do not match what Oauth2ScopeManager actually triggers.

The test asserts messages in the form:

deprecated in version simple_oauth:6.0.0

But Oauth2ScopeManager emits:

deprecated in simple_oauth:6.0.0 and is removed from simple_oauth:7.0.0

Because the strings do not match, the test fails with an unexpected deprecation error.

Proposed resolution

Update all four $this->expectDeprecation() calls in Oauth2ScopePluginManagerLegacyTest to match the strings that Oauth2ScopeManager actually triggers. No logic changes are needed anywhere else.

Remaining tasks

  • Update the four expectDeprecation() strings in modules/simple_oauth_static_scope/tests/src/Kernel/Oauth2ScopePluginManagerLegacyTest.php
  • Confirm 6.1.x CI goes green

User interface changes

None.

API changes

None.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

attilatilman created an issue. See original summary.

attilatilman’s picture

Assigned: attilatilman » Unassigned
Status: Active » Needs review
pfrilling’s picture

Status: Needs review » Reviewed & tested by the community

The code looks good to me.

Note, the CI won't pass until #3620861: Fix user_pass_reset_url() deprecation compatibility in AuthCodeFunctionalTest lands.

bojan_dev made their first commit to this issue’s fork.

bojan_dev’s picture

Status: Reviewed & tested by the community » Fixed

Thank you!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.