Active
Project:
Simple Dialog
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
29 Jan 2015 at 16:11 UTC
Updated:
21 Dec 2017 at 10:20 UTC
Jump to comment: Most recent
if you make the default width lets say 500px and the width of the device is 300px the dialog is still 500px wide
putting width:auto has other problems
if I put "width:auto;height:auto;position:[center,80]"
the dialog opens with left side in center and width occupies half of the screen
and trying to drap it from the title makes it resizeable
needs work to be able to accomodate responsive sites
Comments
Comment #1
HAg commentedThe problem is, that, like other similar modules, Simple Dialog relies on jQuery, which limits the options and produce undesirable in-line style. All in all, it is bad practice to use JavaScript for position and resizing, since both can be done quicker and smoother using css, and because JavaScript usually use another bad practice, in-line style.
I have tried a lot of similar modules. Simple Dialog is far from being the worst, when it comes to theming, but there is definitely room for improvements, and we really need a modal module with a thought-out theming.
Comment #2
philsward commented+1 | Doesn't work with Bootstrap on account of jquery issues.