Signups for signup-enabled nodes aren't getting closed automatically when the signup limits are reached. This appears to be due to an issue with the logic in signup_status_nodeapi(), which is not correctly computing and setting the signup limit. The limit is, therefore, saved as 0 (unlimited), and this prevents the signup module from knowing it should close the signups when the limit is reached.

Comments

jrbeeman’s picture

jrbeeman
he/him
Primary language English
Location Arizona, USA
commented

The first issue here is that it is attempting to parse through *all* status codes, including the "cancelled" code of zero. This is most likely due to a recent change to the signup_status_codes() method that I made, but didn't account for in this code block.

jrbeeman’s picture

jrbeeman
he/him
Primary language English
Location Arizona, USA
commented

Turns out it's because it was attempting to set the value of $node->signup_close_signup_limit after it had been used and saved by signup.module (precedence). I've moved this logic into the 'submit' op of hook_nodeapi and all seems to be well.

Fixed in 5.x-dev as of r108889.

jrbeeman’s picture

jrbeeman
he/him
Primary language English
Location Arizona, USA
commented
Status: Active » Fixed
pelicani’s picture

pelicani commented
Status: Fixed » Active

We have the latest version and the signup is not closing when the limit is met.
Also, I notice the latest signup seems to implement their own version of limits that are not integrated with signup_status.
Please comment, as I'd like to know where this is going.

iamwhoiam’s picture

iamwhoiam commented

indeed, my signups are definitely not being closed

wadebarker’s picture

wadebarker commented

I'm having the same problem. When my number of Registered spots fills up, it keeps going and does not close the event or shift to the waitlist as it should.

UMHockeyFan’s picture

UMHockeyFan commented

Do any of you happen to be running the Signup Scheduler module as well? I disabled Signup Status due to the same issues (signup remains open after meeting and passing limits), but my events would still not close. I looked at the log for my site and noticed that Cron was opening the signups for full events. After I disabled Signup Scheduler, my signups remained closed after they were full. I have submitted a bug to the Signup Schedule module page here: http://drupal.org/node/308813

patricio.keilty’s picture

patricio.keilty commented

My main concern right now, is that signup limit would be set to 0 everytime the node is edited. I had posted a support request #366914: Signup limit set to 0 on submit for someone to explain me what the related code is supposed to do... as pelicani suggested there seems to be 2 distincts versions of limits between signup and signup_status?

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Active » Closed (won't fix)

This version of Signup Status is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.