It was reasonable in the past to go from 4.7.x straight to 6.x. It's no longer reasonable/possible to do that from 6.x to 7.x. I think this module should remove all hook_updates below 6000 (and maybe below 6005) and add some upgrade text that reminds users to use a very recent version of 6.x before updating to 7.x.

The particular motivator for doing this from my perspective is that signup_update_5203 and signup_update_5204 contain queries which are flagged as "critical issues" in coder reviews. There are other ways to address that (like creating an "ignore" file) but that seems equally hacky.

Comments

ezra-g’s picture

I support this. This is also consistent with the recommendation at http://api.drupal.org/api/drupal/developer--hooks--install.php/function/... "A good rule of thumb is to remove updates older than two major releases of Drupal. See hook_update_last_removed() to notify Drupal about the removals."

dww’s picture

No objections. Fire at will. ;)

Thanks,
-Derek

jordojuice’s picture

Status: Active » Needs review
StatusFileSize
new13.55 KB

Removes all hook_update_N() implementations before 6000.

sgabe’s picture

Title: remove old hook_update_N » Remove old updates
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.