i have installed the current git version and have added the patches that seemed logical:
http://drupal.org/node/1112502
and
http://drupal.org/node/1112590

under the signup admin screen, whenever i attempt to change the signup status of an event i get various errors:

Notice: Undefined property: stdClass::$signup_status in _signup_check_limit() (Zeile 1547 von /.../sites/all/modules/signup/signup.module).

Notice: Undefined property: stdClass::$signup_effective_total in _signup_check_limit() (Zeile 1547 von /.../sites/all/modules/signup/signup.module).

Notice: Undefined property: stdClass::$signup_close_signup_limit in signup_node_admin_summary_form_submit() (Zeile 65 von /.../sites/all/modules/signup/includes/node_admin_summary.inc

Notice: Undefined offset: 0 in theme_tableselect() (Zeile 3158 von /.../includes/form.inc).

Warning: Cannot use a scalar value as an array in signup_admin_form_submit() (Zeile 237 von /.../sites/all/modules/signup/includes/admin.signup_administration.inc).

and changes are not reflected upon submitting

is this just me?

CommentFileSizeAuthor
#5 signup-nonzero-tableselect-header-index-1128288.patch948 bytesjwilson3

Comments

discipolo’s picture

discipolo commented
Title: Errors on Aadmin/content/signup » Errors on admin/content/signup
magnusk’s picture

magnusk commented
Category: support » bug

When I visit that page I also get a burst of the following message:

Notice: Undefined offset: 0 in theme_tableselect() (line 3157 of [...]/drupal-7.2/includes/form.inc).
magnusk’s picture

magnusk commented

In function signup_admin_form (file includes/admin.signup_administration.inc) the key for the first element of the header array needs to be 'start' instead of 0.

Replace

    array_unshift($header, $start_column);

with

    $header = array('start' => $start_column) + $header;
magnusk’s picture

magnusk commented
Title: Errors on admin/content/signup » Incorrect header array key in admin/content/signup
Status: Active » Needs review
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new signup-nonzero-tableselect-header-index-1128288.patch948 bytes

#3 works, here is a patch that fixes that line and also removes mention of "CCK" with respect to the row header calculation, since that's pre-D7 terminology now.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

If you're testing/applying this one, you might also review #1190944: Notice: Undefined property: stdClass::$language in _signup_date_get_node_scheduler() which is causing error messages on the same page.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Reviewed & tested by the community » Needs review

While this patch seems pretty right, it's generally inappropriate to mark your own patch as "rtbc." Setting back to "needs review" until someone else can do a review.

boshtian’s picture

boshtian commented

The above solutions worked for me as well, but I still have a warning:
"Warning: Cannot use a scalar value as an array in signup_admin_form_submit() (line 238 of /var/aegir/platforms/drupal-7.8-enki-1.1/sites/www.tp-lj.si/modules/contrib/signup/includes/admin.signup_administration...)."

This line seems to be the problem:
$values['nid'] = $nid;

But I can't figure it out, how to correct this. The form is not submitted. Did anyone else had that issue?

sgabe’s picture

sgabe commented
Status: Needs review » Reviewed & tested by the community

The patch in #5 applies fine and eliminates the following error:

Notice: Undefined offset: 0 theme_tableselect() függvényben ([...]\www\includes\form.inc 3212 sor).

sgabe’s picture

sgabe commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.