Closed (fixed)
Project:
Services
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
19 Apr 2013 at 18:16 UTC
Updated:
4 Jan 2014 at 03:28 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ygerasimov commentedI agree with this issue. Please provide a patch. I am for shorter version 'name', 'pass'.
Comment #2
lisa.rae commentedPatch is attached...
Comment #3
lisa.rae commentedComment #4
ygerasimov commentedPatch won't pass tests. Please correct tests as well.
Comment #5
lisa.rae commentedTests corrected, resubmitting....
Comment #6
kylebrowning commentedId prefer that you used the versioning API that services provides so that this doesnt break peoples clients.
look at services.versions.api.php
Comment #7
lisa.rae commentedSo, use the versioning api instead of patching the user resources and associated tests directly?
Comment #8
kylebrowning commentedyeah because if you change the user resource directly, peoples clients will break when they update Services.
As an example, this is in the user resource and lets admins choose the version they wish to use for the logout method.
Comment #9
lisa.rae commentedThat actually makes perfect sense. I wasn't aware there was an update API.
New patch, patching user_resource.inc to include API version 1.1 for the login endpoint.
Comment #11
ygerasimov commented#9: services-consistent-register-login-parameters-1975954-9.patch queued for re-testing.
Comment #13
lisa.rae commentedok, recreated the patch from inside the module directory this time, resubmitting.....
Comment #14
kylebrowning commentedI hate to be picky, but can we get a test for the new version response? Just create a total new test in the User resource.
leave the old one test intact, but make a new one, pass the version HEADER and verify that the parameters are correct and then this patch will be perfect.
You can see some examples in ServicesVersions.test and dont forget youll need to update the endpoint!
Comment #15
lisa.rae commentedSorry, but I'm looking at the example test, and I don't understand how this works, so it's going to be impossible for me to write a test for this in any reasonable amount of time. I looked for the test case for the logout api version 1.1 and didn't see it -- if you would point me to that one I'll look at it and see if I can figure out what needs to be done.
Comment #16
kylebrowning commentedHeres a patch with tests.
Comment #17
ygerasimov commentedComment #18
ygerasimov commentedCommitted.