If I try to use the files relationship of a node I get a php notice in my log:
Warning: Missing argument 3 for _file_resource_retrieve(), called in /drupal7/sites/all/modules/services/resources/node_resource.inc on line 458 and defined in _file_resource_retrieve() (line 230 of /drupal7/sites/all/modules/services/resources/file_resource.inc).

Attached patch fixed this for me.

CommentFileSizeAuthor
#3 node-file.patch1.77 KBmarcingy
services-file_resource_notice.patch501 byteswedge

Comments

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Needs work

The patch technically solves the problem, but I think heres a larger bug that won't pass the default value false off to this function.

REST server handles filling in the default values and I think the issue might be that it doesn't like false as a default value.

marcingy’s picture

marcingy commented

The issue is that _node_resource_load_node_files does not accept the new additional parameter, and pass it onwards.

marcingy’s picture

marcingy commented
Status: Needs work » Needs review
StatusFileSize
new node-file.patch1.77 KB

This should fix the issue.

wedge’s picture

wedge commented

Thanks Marc, that works for me also.

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Reviewed & tested by the community

looks good.

marcingy’s picture

marcingy commented
Status: Reviewed & tested by the community » Fixed
kylebrowning’s picture

kylebrowning commented
Status: Fixed » Closed (fixed)