Hi,

Thanks for the module!

I'll love to have the option to remove also the default classes of the wrapper element. We're a little obsessed with creating clean HTML lately.

I've attached a patch that changes the way the settings form works. It adds three checkboxes "Add default classes" checked by default.

BR,

CommentFileSizeAuthor
#2 1826764-allow-removing-wrappers-default-classes-2.patch5.25 KBmcjim
allow-removing-wrappers-default-classes.patch4.68 KBluisortizramos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

luisortizramos’s picture

luisortizramos CreditAttribution: luisortizramos commented
Status: Needs review » Reviewed & tested by the community

I've been using it for a week and the patch works fine. So I'm marking it as reviewed by the community.

mcjim’s picture

mcjim CreditAttribution: mcjim commented
Status: Reviewed & tested by the community » Needs review
FileSize
1826764-allow-removing-wrappers-default-classes-2.patch5.25 KB

Updated patch to apply to latest dev.

Review of previous patch: great idea! More control over the default classes is very welcome.

berdyshev’s picture

berdyshev CreditAttribution: berdyshev commented
Status: Needs review » Needs work

@mcjim, what is the different between two patches? As I can see, you have just attached the same patch as in topic but with wrong file paths.

pyxio’s picture

pyxio CreditAttribution: pyxio commented

I was wondering since these are only notices and critical to proper functionality, is there anyway to turn them off within the module itself so they we can still use the module but these notices don't overwhelm the log? If there is a temporary patch for that it would be greatly appreciated until the issue generating the notices is resolved. cheers Kevin