conflict with drush (headers already sent)

I can't reproduce this - appears to be working fine with drush locally.

I had the same problem, I tracked it down to Secure Pages outputting headers in hook_boot() and hook_init().

In my patch I checked to see if the drush_main() function exists, if so we return at the beginning of the hooks not outputting any headers.

I just put the following at the top of hook_init and hook_boot:

if (php_sapi_name() == 'cli') {
  return;
}

+++ securepages.module	20 Feb 2010 04:03:15 -0000
@@ -10,6 +10,10 @@
+  if (function_exists('drush_main')) {
+    return NULL;
+  }

Shouldn't check for for the function drush_main(). Should check to see if php is running in a shell. Much more generic

+++ securepages.module	20 Feb 2010 04:03:15 -0000
@@ -46,7 +50,7 @@ function securepages_boot() {
-  if (!variable_get('securepages_enable', 0) || basename($_SERVER['PHP_SELF']) != 'index.php') {
+  if (!variable_get('securepages_enable', 0) || basename($_SERVER['PHP_SELF']) != 'index.php' || function_exists('drush_main')) {
     return;

Same as above.

Use php_sapi_name() instead. will make it much more generic. Will fix for all shell based bootstrapping of Drupal.

Powered by Dreditor.

gorden...see #4

Yes, but I still need a patch.

Subscribing. Patch for solution in #4 attached.

Ran into this issue when testing this module. I had to go into admin/build/modules in a browser (gasp!) and uncheck a box (gasp!) to turn the module off so I could use drush.

This patch applies fine and resolves the issue.

Keeping track of this thread...

Subscribing.

#8 works for me.

Before:

$ drush --verbose cron
Initialized Drupal 6.19 root directory at /home/drupal/public_html        [notice]
Initialized Drupal site default at sites/default                        [notice]
Cannot modify header information - headers already sent by (output   [warning]
started at /home/drupal/public_html/drush/includes/drush.inc:820)
securepages.module:192
Drush command could not be completed.                                [error]

After:

$ drush.php --verbose cron  
Initialized Drupal 6.19 root directory at /home/drupal/public_html        [notice]
Initialized Drupal site default at sites/default                        [notice]
WD cron: Cron run completed.                                            [notice]
Cron run successfully.                                               [success]
Command dispatch complete                                               [notice]

This is critical for me but might not be for others, so feel free to lower priority.

The issue priorities are all specifically defined:
http://drupal.org/node/45111

Thanks for pointing out that page. It says:

Critical bugs either render a system unusable (not being able to create content or upgrade between versions, blocks not displaying, and the like), or expose security vulnerabilities. These bugs are to be fixed immediately.

I guess the word "system" is not defined enough for you? In short, this bug breaks Drush and therefore renders my system unusable. For example, I need to able to use Drush to run cron, perform routine maintenance, etc. and all my shell scripts containing Drush commands come to a halt.

Anyway, I said to feel free to lower the priority but I've changed my mind. If you still feel the same as you do in #13, do what you want.

Patch seems to work for me, but once applied I cannot get into the secure pages settings in a browser.

Has anyone else had this problem, or indeed checked afterwards?

EDIT: Had moved module into a site specific directory too and this was the problem. Patch working fine - thanks guys:)

Committed a variation of this to 6.x and CVS HEAD. Thanks!