Hi,

The 'algorithm' and 'exclusions' links are broken if you go to the settings form on the 'Stem Words' processor settings form. The links are highlighted in the screenshot attached.

The links have been passed to the t() function with @ when they have been written with !:

$args = array(
      '!algorithm' => url('https://github.com/markfullmer/porter2'),
      '!exclusions' => url('https://github.com/markfullmer/porter2#user-content-custom-exclusions'),
    );
    $form += array(
      'help' => array(
        '#markup' => '<p>' . t('Optionally, provide an exclusion list to override the stemmer algorithm. Read about the <a href="@algorithm">algorithm</a> and <a href="@exclusions">exclusions</a>.', $args) . '</p>',
      ),

Patch to follow to run these through l() instaed of building the link and to remove the exclusions link as it no longer exists.

Cheers

Tom

Comments

blacklabel_tom created an issue. See original summary.

blacklabel_tom’s picture

Status: Active » Needs review
StatusFileSize
new1.06 KB
drunken monkey’s picture

Component: General code » Plugins
StatusFileSize
new1.06 KB

Thanks a lot for catching that! Really stupid mistake – curious that nobody noticed this before.
Anyways, not using l() is actually part of the Drupal coding standards and therefore on purpose. Let's just correct the link, but also let it point to a page actually explaining the algorithm.

drunken monkey’s picture

Status: Needs review » Fixed

Committed.
Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.