Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

according to the test results there's a problem on the permissions.

https://qa.drupal.org/pifr/test/1171523

I'm working on a similar HEAD broken case for webform_internationalization and came accross a possible solution to permission issues.

Apparently the permission cache might need to be reset after (OR in this case, BEFORE) each call to drupalCreateUser
see possible solution here: https://api.drupal.org/comment/28739#comment-28739

there could be other problems as well with the simple tests, however I'm focussing on the permissions error:
Line 89 search_api.test

$this->drupalLogin($this->drupalCreateUser(array('administer search_api')));

The test bot says: Invalid permission administer search_api.

Perhaps we might try calling

$this-­>checkPermissions(array('administer search_api'), TRUE) ;

right before line 89

again, see this comment "reset permission cache"

joseph.olstad’s picture

Status: Active » Needs review
StatusFileSize
new536 bytes

I expect this to fail, but will use the results of the failure to create a new patch.

Status: Needs review » Needs work
joseph.olstad’s picture

Status: Needs work » Needs review
StatusFileSize
new538 bytes

should be checkPermissions , not checkPermission

try again

Status: Needs review » Needs work
joseph.olstad’s picture

Status: Needs work » Needs review
StatusFileSize
new625 bytes

Excellent, that was helpful, now here for the real patch that will fix the issue:

joseph.olstad’s picture

Status: Needs review » Reviewed & tested by the community

Lets get this fix in. Its blocking testing of other real issues.

drunken monkey’s picture

Issue summary: View changes
StatusFileSize
new250 bytes

Weird stuff, thanks for reporting and posting a patch!
However, according to the module's "Automated testing" tab the tests are currently passing, yesterday was the latest run. So maybe this was fixed in the meantime?
Posting a no-op patch for testing.

drunken monkey’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new250 bytes
joseph.olstad’s picture

Status: Needs review » Closed (cannot reproduce)

ok, looks like the issue is no longer a problem.