We had a short discussion about terminology at our D8 BoF in Amsterdam. The results:

  • "Data source" stays as it is, was voted better than the alternatives.
  • "Processors" are also OK (so the tab should be renamed to that), but we should make clear what they do (maybe annotating them with the phases in which they run – see (part of) #2044311: Change workflow plugin system). Also, it might be good to move those processors that just provide a new field to the "Fields" tab in some nifty way.

To do in this issue: rename the "Filters" tab, change the label for datasources in the index's view tab to singular "Data source", and create new issues for additional related UI improvements.

CommentFileSizeAuthor
#8 2348185-8--filters_processors_renaming--interdiff.txt2.7 KBdrunken monkey
#8 2348185-8--filters_processors_renaming.patch10.49 KBdrunken monkey
#7 search_api-renaming_labels-2348185-6.patch29.69 KBp-neyens
#5 search_api-renaming_labels-2348185-5.patch27.16 KBp-neyens

Comments

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Project: Search API » Search API (8.x)
Version: 8.x-1.x-dev »
Issue summary: View changes

Can already happen in the sandbox.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Project: Search API (8.x) » Search API
Version: » 8.x-1.x-dev
Component: Framework » User interface

But it didn't, so back it goes …

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Issue tags: +Novice
p-neyens’s picture

p-neyens commented
Assigned: Unassigned » p-neyens
p-neyens’s picture

p-neyens commented
Status: Active » Needs review
StatusFileSize
new search_api-renaming_labels-2348185-5.patch27.16 KB

Patch summary:
- Replaced the label for the 'Filters' tab to 'Processors' and all related chances to that like routing, renaming form class...
- Replaced the index view datasource label to 'Data source' and the index edit datasource label to 'Data sources' as well.

Status: Needs review » Needs work

The last submitted patch, 5: search_api-renaming_labels-2348185-5.patch, failed testing.

p-neyens’s picture

p-neyens commented
Status: Needs work » Needs review
StatusFileSize
new search_api-renaming_labels-2348185-6.patch29.69 KB

Fix IntegrationTest and ProcessorIntegrationTest.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 2348185-8--filters_processors_renaming.patch10.49 KB
new 2348185-8--filters_processors_renaming--interdiff.txt2.7 KB

Thanks a lot, good work!
You just forgot a few instances, but now I think/hope we have all.
(Also, the patch needed a re-roll anyways.)

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Committed.
Thanks a lot again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.