We had a short discussion about terminology at our D8 BoF in Amsterdam. The results:

  • "Data source" stays as it is, was voted better than the alternatives.
  • "Processors" are also OK (so the tab should be renamed to that), but we should make clear what they do (maybe annotating them with the phases in which they run – see (part of) #2044311: Change workflow plugin system). Also, it might be good to move those processors that just provide a new field to the "Fields" tab in some nifty way.

To do in this issue: rename the "Filters" tab, change the label for datasources in the index's view tab to singular "Data source", and create new issues for additional related UI improvements.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey’s picture

Project: Search API » Search API (8.x)
Version: 8.x-1.x-dev »
Issue summary: View changes

Can already happen in the sandbox.

drunken monkey’s picture

Project: Search API (8.x) » Search API
Version: » 8.x-1.x-dev
Component: Framework » User interface

But it didn't, so back it goes …

drunken monkey’s picture

Issue tags: +Novice
p-neyens’s picture

Assigned: Unassigned » p-neyens
p-neyens’s picture

Status: Active » Needs review
FileSize
27.16 KB

Patch summary:
- Replaced the label for the 'Filters' tab to 'Processors' and all related chances to that like routing, renaming form class...
- Replaced the index view datasource label to 'Data source' and the index edit datasource label to 'Data sources' as well.

Status: Needs review » Needs work

The last submitted patch, 5: search_api-renaming_labels-2348185-5.patch, failed testing.

p-neyens’s picture

Status: Needs work » Needs review
FileSize
29.69 KB

Fix IntegrationTest and ProcessorIntegrationTest.

drunken monkey’s picture

Thanks a lot, good work!
You just forgot a few instances, but now I think/hope we have all.
(Also, the patch needed a re-roll anyways.)

drunken monkey’s picture

Status: Needs review » Fixed

Committed.
Thanks a lot again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.