Search for node content in current language

Hi Shaal!

Thanks for the patch and referencing the related issue #3041039: Search for content in current language. These maybe duplicates of each other, but I'll leave that for someone else to decide.

I've updated the issue summary so someone can see this related issue more prominently.

I've changed the status to Needs Review to hopefully get some eyes on it. To me this seems like a fine path forward that will needs tests associated with it.

I think we'll need to get consensus on the path forward first before putting time into tests.

@shaal

Please find the below feedback of patch#2:

1. All the test cases which you have mentioned is working fine and tested for both anonymous and admin user.

2. Strange things I have found is that when you open the advance search and put keyword 'chocolate' with English language then you will find total 3 result as expected but in the normal Search box you will get two keywords 'chocolate chocolate' which gets increase if you put the same in the advance search.

3. Normal Search (en/search/node) : At the same time in the normal search keyword, search only with 'chocolate' and you will get the 3 results as expected. Now open the Advance search and select both languages and click on the normal search button and you will get total 6 results in this case. As per my understanding Search and Advance Search both shouldn't be mixed up in this case. The issue related to search URL where the keywords just getting added and not cleared. Need to work on this.

4. Patch#2 also needs changes related to coding standard which you can find from the codesniffer_fixes.patch result in your patch.

Fixed all the failures.

hi all,

please find an updated patch for D8.9.x.

sorry, forgot the comments at the top.

Patch #13 can't be applied on 9.2.x.Needs reroll.

Checking patch core/modules/node/src/Plugin/Search/NodeSearch.php...
error: while searching for:
    // We need to parse this out into query conditions, some of which go into?
    // the keywords string, and some of which are separate conditions.?
    $parameters = $this->getParameters();?
    if (!empty($parameters['f']) && is_array($parameters['f'])) {?
      $filters = [];?
      // Match any query value that is an expected option and a value?

error: patch failed: core/modules/node/src/Plugin/Search/NodeSearch.php:288
error: core/modules/node/src/Plugin/Search/NodeSearch.php: patch does not apply

Rerolled patch #13

Here is the patch which has fixed the fails of #16

#16 is working on 9.2.1

#16 is working on 9.2.10 for me too

Re-rolled #19 for latest 9.3.x

The patch #24 is applied on drupal version 9.5 successfully and this patch also applied on the latest branch and it working fine.
Thankyou

Verified and tested patch #24 on 10.1.x-dev. Patch applied successfully.

Test Results:
1. When no language is chosen in advance-search and normal search, display results only in current language.
2. Issue #5 point 2 (5.2) is reproducible after applying patch

in the normal Search box you will get two keywords 'chocolate chocolate' which gets increase if you put the same in the advance search.

Basically, keyword searched in Advanced-search "Containing any of the words" field is cleared from advance search box and appended to normal search box. And this results in increase of same keywords - "test test".

Moving to Needs Work

Re-rolled #24 for latest 10.3.x

The Search Module was approved for removal in #3476883: [Policy, no patch] Move Search module to contrib .

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3565780: [meta] Tasks to deprecate the Search module and the removal work in #3565783: [meta] Tasks to remove the Search module.

Search will be moved to a contributed project before Drupal 12.0.0 is released.

The Search Module has moved from core to contrib,