apparently because the 'scorm_cloud_css' variable is not properly stored in the database when the SCORM Cloud CCK field definition is created or updated. I've searched the 'variable' array in my MySQL database and the 'scorm_cloud_css' record is not there. Neither do I see it being created in the code.

Thus line 801 in scorm_cloud.module will not retrieve the css override file name...
Line 801: $css = variable_get('scorm_cloud_css', '');

Trying to figure out the solution OR ronan will need to fix.

Comments

webservant316’s picture

webservant316 commented

more thoughts...

line 801 seems to be referencing a global variable from when we initially had the css override in the admin settings. however, we then moved the css override into the SCORM Cloud field definition. So maybe the css override is stored properly in the database, or maybe not.

Regardless this feature is not working properly and the code may need some clean up now that the value is stored solely in the CCK definition.

ronan’s picture

ronan commented
Status: Active » Postponed (maintainer needs more info)

I just pushed a fix so that the specified css url is getting passed through to the API. As noted before though (before the changes we made broke the css handling in the module), I can't see it having any effect on the launched course, so I'm really not sure what else needs to be done to get this to actually do anything.

webservant316’s picture

webservant316 commented

thanks, I'll give it a try. welcome back :-)

webservant316’s picture

webservant316 commented

Hey good news!! your fix worked. I now see the css override in the course launch page .

<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<meta content="IE=EmulateIE8" http-equiv="X-UA-Compatible">
<link type="text/css" href="http://.../sites/default/files/cloudstyles.css" rel="stylesheet">

Ronan if you can respond to this ticket with a little more detail as to what we were doing that didn't work and what change you made that did work that might be useful. I will direct the SCORM Cloud API guys to check this post.

So as of today no known issues in the module. Super!

ronan’s picture

ronan commented
Status: Postponed (maintainer needs more info) » Fixed

The most recent thing I fixed was simply that I was no longer passing the css path through to the API. The problem was entirely in my code and happened when we switched from using direct links for preview/launch to using redirected links (because of the expiring link issue). I just added some code so that the custom css gets passed through to the launch link.

Not sure why I wasn't seeing the test css show up anywhere, but as long as you are then I think we're good.

webservant316’s picture

webservant316 commented

The SCORM Cloud player is a window that iframes in the SCORM Course window. The override CSS applies to the SCORM Cloud player window and not the SCORM Course window. In my original settings the SCORM Course was being launched in a new window so the SCORM Cloud player window was actually the blank window behind the course. When you created the ability to edit all the SCORM course launch settings from the node I began to play with the settings with greater understanding. So now can can easily understand the difference between the player window and the course window. My personal preference is the launch the course embedded or iframed into the player window (less windows flying around). And again the CSS override applies to the player window.

Anyway before your fix above the CCS override wasn't evident in either window, but now it is evident in the player window just as it should be.

Thanks again.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.