Refactor the codebase to use DI instead of \Drupal service calls.

Issue fork scanner-3584431

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

damienmckenna created an issue. See original summary.

sourav_paul’s picture

sourav_paul
Location Kolkata
commented

Working on this.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Thank you!

Please update the "assigned" field to set it to your name and then set it back to "Unassigned" when you're finished; that's how we track who's working on what.

sourav_paul’s picture

sourav_paul
Location Kolkata
commented
Assigned: Unassigned » sourav_paul

Thanks @damienmckenna, to let me know the tracking policy.

sourav_paul opened merge request !62

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs work

Thank you for working on that. It seems the service definition needs a little work, it's causing the tests to fail.

sourav_paul’s picture

sourav_paul
Location Kolkata
commented

Thanks @damienmckenna for your guidance, I tried to address the PHPUnit failure with some help from ChatGPT and updated the logger dependency to use logger.factory instead of logger.channel.scanner, but I still could not get the tests passing reliably.

It looks like I may be missing something in the service wiring or test setup. If anyone has a moment to take a look and guide me here, I’d really appreciate the help.

dimitriskr’s picture

dimitriskr commented
Assigned: sourav_paul » dimitriskr
dimitriskr’s picture

dimitriskr commented
Assigned: dimitriskr » Unassigned

Pipeline is green now. Batch operations cannot handle DI and need to be static so I reverted that

dimitriskr’s picture

dimitriskr commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Postponed
Related issues: +#3584678: Refactor search logic to use a method in Entity class, +#3584659: Refactor replacement logic to use a method in Entity class

This will need to be refactored after #3584678: Refactor search logic to use a method in Entity class and #3584659: Refactor replacement logic to use a method in Entity class are done.