Problem/Motivation

Each entity class has logic that processes each field based on its type. This is excessive.

Proposed resolution

Add methods in Entity for processing the search of a given field on that entity.

Remaining tasks

Add methods in Entity for processing the search of a given field on that entity.
Add test coverage.

User interface changes

n/a

API changes

TBD

Data model changes

n/a

Issue fork scanner-3584678

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

damienmckenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: Unassigned » damienmckenna

This needs to:

  • Loop through the enabled fields for the entity.
  • Loop over each item in the field, to allow for multi-value fields.
  • Delegate the field handling to separate methods, which we may split off to separate plugins.
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3577750: Plan for Scanner 2.0.0

This needs to be done before 2.0.0.

damienmckenna opened merge request !65

damienmckenna changed the visibility of the branch 2.0.x to hidden.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review

  • damienmckenna committed 32dfea8b on 2.0.x 
    Issue #3584678 by DamienMcKenna: Heavily refactored search logic.
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned
Status: Needs review » Fixed

Committed. This is a major improvement and simplification of the module, it'll make adding support for other entities a lot easer.

Still to go - refactor the Entity::replace() logic in #3584659: Refactor replacement logic to use a method in Entity class.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.