Why does this module change the title of "Publishing options" fieldset to "Promotion settings"?

It is confusing to have the "Create new revision" checkbox under "Promotion settings", since it has nothing to do with promotion. The more generic "Publishing options" is much better. It gets even worse when using the panopoly_admin module of the Panopoly distribution since that hides the sticky and promoted checkboxes, so the fieldset now only contains the "save new draft" settings.

I propose leaving the title as it is. Patch attached.

CommentFileSizeAuthor
#6 2717187-publishing-label-6.patch556 bytespravin ajaaz
#2 save_draft-fieldset_title-2717187-1.patch601 bytesAndreas Radloff

Comments

Andreas Radloff created an issue. See original summary.

Andreas Radloff’s picture

Andreas Radloff commented
StatusFileSize
new save_draft-fieldset_title-2717187-1.patch601 bytes
Andreas Radloff’s picture

Andreas Radloff commented
Issue summary: View changes
Karthikeyan R’s picture

Karthikeyan R commented
Status: Active » Reviewed & tested by the community

I reviewed the patch.It works for me.

pravin ajaaz’s picture

pravin ajaaz commented
Status: Reviewed & tested by the community » Needs work

Patch needs re-roll

pravin ajaaz’s picture

pravin ajaaz commented
Status: Needs work » Needs review
StatusFileSize
new 2717187-publishing-label-6.patch556 bytes

  • Pravin Ajaaz committed b9b94e0 on 7.x-1.x 
    Issue #2717187 by Andreas Radloff, Pravin Ajaaz, Karthikeyan R: Do not...
pravin ajaaz’s picture

pravin ajaaz commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.