Of importance: enable/disable, but the more thorough, the better.
Reorganizing under "stat methods" component.
This actually might not be possible until Entity gets Entity Manager injected properly: #2015535: Improve instantiation of entity classes and entity controllers
While thinking through it, though, I think we should move the SAPI method plugin manager cache clear out of StatMethod and into StatMethodStorageController. Separate issue for that here: #2052147: Move the Stat Method plugin clearCachedDefinitions() call from StatMethod to StatMethodStorageController
In the meantime, marking postponed until the aforementioned Entity Manager injection issue is taken care of.
Adding "Stat" to the list of classes that need testing. Still waiting on #2015535: Improve instantiation of entity classes and entity controllers.
The Stat and StatMethod concepts are no longer used, but UnitTests are needed still.
I will move the testing requirement to new issues
Comments
Comment #1
iamEAP commentedReorganizing under "stat methods" component.
Comment #2
iamEAP commentedThis actually might not be possible until Entity gets Entity Manager injected properly: #2015535: Improve instantiation of entity classes and entity controllers
While thinking through it, though, I think we should move the SAPI method plugin manager cache clear out of StatMethod and into StatMethodStorageController. Separate issue for that here: #2052147: Move the Stat Method plugin clearCachedDefinitions() call from StatMethod to StatMethodStorageController
In the meantime, marking postponed until the aforementioned Entity Manager injection issue is taken care of.
Comment #3
iamEAP commentedAdding "Stat" to the list of classes that need testing. Still waiting on #2015535: Improve instantiation of entity classes and entity controllers.
Comment #4
jaxxed commentedThe Stat and StatMethod concepts are no longer used, but UnitTests are needed still.
Comment #5
jaxxed commentedI will move the testing requirement to new issues