I'm trying to move my idp pub key out of my config and into a file on disk. I've selected the "File" under "Type of values to save for the certificate(s)", and i've entered the absolute path of the file on disk.

Unfortunately, even though the file definitely exists on disk, it always shows "IdP encryption certificate file is missing."

As far as I can tell, the $encryption_cert variable here is blank, which is the problem.

CommentFileSizeAuthor
#6 bogus_warning_idp_encryption_cert-3220150-6.patch2.15 KBhotwebmatter

Comments

bricas created an issue. See original summary.

  • roderik committed 7946055 on 8.x-3.x 
    Issue #3220150 by bricas, roderik: remove bogus warning about IdP...
roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Title: IdP cert as file can't be found » (bogus warning) IdP encryption cert as file can't be found
Status: Active » Fixed

Thank you for the report. It's predictable that some errors would show up because of the lack of automated tests :-|

The warning you're seeing is bogus. The separate "encryption certificate" is optional and the vast majority of users don't populate it. (The form element to enter "Encryption Certificate Filename" is often disabled.)

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented

Added a warning in https://www.drupal.org/project/samlauth/releases/8.x-3.3, because I'm not going to tag a new release for this yet.

To be clear: the warning will stay around every time you view the configuration screen - but it should not affect the functioning of this module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

hotwebmatter’s picture

hotwebmatter commented
StatusFileSize
new bogus_warning_idp_encryption_cert-3220150-6.patch2.15 KB

Thanks for the fix roderik!

Just in case anyone wants to apply the patch before the next release comes out, here it is as an old-school patch.

It's funny, I just got used to making PRs instead of patches :)

Anyway, I generated this patch by getting the diff between this commit and the one before it:

$ git diff ab45f31a 79460551 > patch.diff

Then, for historical reasons:

$ mv patch.diff bogus_warning_idp_encryption_cert-3220150-6.patch

Now I can add add this patch to my project with cweagans/composer-patches and my clients don't have to see this warning.