Since we're dealing with potentially sensitive (and potentially legally protected) information, we should put this module through the wringer w.r.t security. There are a couple issues posted already about some potential security holes - #782308: exposing salesforce username, password, and token in variables table is a security risk, #782314: WSDL in web accessible path is a security risk. What about incoming transaction forgeries? API Sessions? XSS opportunities? Countless other potential holes?

Comments

aaronbauman’s picture

aaronbauman
he/him
commented

adding
#477182: Encrypt API password and token

kostajh’s picture

kostajh commented

Coder did not find anything when running the module through its security check.

#500052: Allow salesforce to initiate imports included restricting access for sf_notifications by IP.

I would say that when #477182: Encrypt API password and token is in, we could close this ticket and open issues as they arise.

EvanDonovan’s picture

EvanDonovan commented

It's in now; thanks Aaron!

I agree with kostajh.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Active » Fixed

awesome

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.