There are a pair of upsert operations that need try/catch handling.

Patch to follow.

CommentFileSizeAuthor
#10 1142500-exceptionhandling-5.patch3.14 KBdpearcefl
#8 1142500-exceptionhandling-4.patch3.08 KBdpearcefl
#7 1142500-exceptionhandling-3.patch2.92 KBdpearcefl
#2 1142500-exceptionhandling-2.patch1.49 KBdpearcefl
#1 1142500-exceptionhandling.patch1.48 KBdpearcefl

Comments

dpearcefl’s picture

dpearcefl commented
Status: Active » Needs review
StatusFileSize
new 1142500-exceptionhandling.patch1.48 KB
dpearcefl’s picture

dpearcefl commented
StatusFileSize
new 1142500-exceptionhandling-2.patch1.49 KB

DOH! Better patch attached.

kostajh’s picture

kostajh commented
Status: Needs review » Needs work

Thanks for submitting this. This looks fine but the same would be needed for sf_user too. Also, I think it would be better if this issue #1058920: Create generic upsert function (for use in all cases of Drupal->SF entity export, etc.) gets addressed first.

dpearcefl’s picture

dpearcefl commented

I completely agree but that issue has sat undisturbed for almost three months. Unless someone agrees to take it on now, perhaps this issue (that has a patch) should proceed.

kostajh’s picture

kostajh commented

Ok, fair enough. Do you have time to write the corresponding code for sf_user?

dpearcefl’s picture

dpearcefl commented

Sure. It will be a day or two.

dpearcefl’s picture

dpearcefl commented
Title: Exception catches needed in sf_node » Exception catches needed in sf_node and sf_user
Status: Needs work » Needs review
StatusFileSize
new 1142500-exceptionhandling-3.patch2.92 KB

Patched attached to address similar issues in sf_user and sf_node.

dpearcefl’s picture

dpearcefl commented
StatusFileSize
new 1142500-exceptionhandling-4.patch3.08 KB

Better patch. I included a dump of $e in the watchdog entry when a failure occurs. Lots of good info in there for debugging.

kostajh’s picture

kostajh commented

Would you mind rebasing this against 6.x-2.x-dev? I'll make sure it gets in soon after.

dpearcefl’s picture

dpearcefl commented
StatusFileSize
new 1142500-exceptionhandling-5.patch3.14 KB

Patch attached.

kostajh’s picture

kostajh commented
Status: Needs review » Fixed

Great, thank you! Committed: http://drupalcode.org/project/salesforce.git/commit/3ff527c

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.