Postponed (maintainer needs more info)
Project:
Rules HTTP Client
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
19 Jun 2017 at 03:53 UTC
Updated:
10 Feb 2022 at 16:57 UTC
Jump to comment: Most recent
Comments
Comment #2
tr commented@ajayNimbolkar: It looks like you were made a maintainer 11 months ago, so this issue can be closed (why didn't you close it yourself?).
Are you planning to do anything else with the module? You haven't made any commits or answered any issues for the past 11 months ...
Comment #4
mitchell commentedAjay, do you have any future plans with this project?
(aside: please use this issue to take credit for your contribution: https://www.drupal.org/getting-involved/maintainer/grant-issue-credits . if you plan to alter project history, please ask a d.o maintainer for advice beforehand if you have any questions.)
Comment #5
mitchell commentedComment #6
sgroundwater commentedThis module currently has inputs form for: URL, Header, Method, Data, Max Redirects. Unfortunately it lacks an Authentication input.
Drupal 8 REST supports cookie and basic_auth for authentication. I'd like work on a patch to better support D8 Authentication, with some documentation too.
My question is, is anyone watching/working on this project? - PING - Would there be any interest in moving this plugin into the "D8 Rules Essentials" module? There's a lot of current development activity taking place in D8RE.
This module has value and potential for the community. Thanks for everyone's time!
Comment #7
mitchell commented> My question is, is anyone watching/working on this project? - PING
It doesn't look like it. I only planned to put the code here temporarily so it was available and to do all the planning and merging through https://www.drupal.org/project/rules/issues/1703350
> Would there be any interest in moving this plugin into the "D8 Rules Essentials" module?
Looks like TR runs that. @TR, how do you like that plan?
~~
@sgroundwater, as they say, Drupal is a doocracy. So if someone wants a decision made, then look to whoever is taking action.
Comment #8
sgroundwater commentedRE doocracy, I don't want to over commit, but I need these types of Rules features badly, so I'll help where possible. I was going to attempt a patch/pull-request to fold things into D8 Rules Essentials. I don't want/need to bother @TR until I have this ready, he's very busy.
My intentions ...
- As courtesy I wanted to check with original maintainers and others before proceeding. I'm not sure the background of this module and don't want to step on any toes.
- Helping to take on this piece will be a lift for my skills, I think I can do it. (this should be easy right?) I don't want to duplicate effort, especially if others are working on better solutions.
- I wanted to leave a public trail of why people talked about forking this module into another project. The community is in need of a robust D8 Rules platform, we have limited resources. The D8 Rules Essentials module, as an enhancement to Rules, seems to have the momentum at the moment.
For now, we can continue the discussion herehttps://www.drupal.org/project/rules/issues/1703350. Ultimately this may need to move from the Rules issues over to Rules Essentials. I'm proposing we move this module into a plugin there, if this makes sense.
Comment #9
ajaynimbolkar commented@mitchell,@sgroundwater,
I have already ported rule_http_client in drupal 8 and I am having full knowledge of this module.
Currently I am planning to add basic Authentication features in that module.
Please let me know any new features you want to introduce.
Thanks,
Ajay
Comment #10
sgroundwater commented@Ajay, Thank you for both checking in on this and for your all your work porting rule_http_client to 8.
As an end user, it is painful to have to install a bunch of sub-modules for functionality. You have to know these helpful modules exist in the first place. (I discovered this module by chance.)
This module provides a very useful feature and is small. To make things better, how would you feel about joining forces to help fold this into tr_rulez project? (If that makes sense to people.) It looks like this would drop right as an action plugin to tr_rules.
I'm not part of the tr_rules project. I just need Rules to work so I'm jumping in to work on things.
Side note: Adding basic auth looks like something I could help with given my skill level. @Ajay, you can probably do is better/faster than me :-) If you're working on this great, big thanks, please keep us posted on the progress.
Comment #11
sgroundwater commented@Ajay, I was just throwing out ideas, and checking if this module was alive. I've read through RulesHttpClient.php pretty well. As noted with authentication, it looks like a few improvements could be had. If needed, I want to help with this and documentation too. The workings of what this module does are tricky, people are going to need documentation for how to use this. (Maybe people who need this mod know just what they're after.)
I'll open issue here for further discussion.
Thanks Again.
Comment #12
ajaynimbolkar commentedHi @sgtoundwater,
Thanks for your valuable feedback regarding this module.I will add all points mention by you.
Thanks
Comment #13
abhinesh