Enabling testing with the module installed on a server running PHP 7.1 returns the following error:

Fatal error: Constant expression contains invalid operations in /app/public_html/sites/all/modules/contrib/rules_forms/rules_forms.test on line 121
CommentFileSizeAuthor
#3 3017846-3.patch869 bytesjoelpittet

Comments

ultrabob created an issue. See original summary.

ultrabob’s picture

ultrabob commented

The t() function is what is causing it to not like this being static.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new 3017846-3.patch869 bytes

Removing the t() calls.

Status: Needs review » Needs work

The last submitted patch, 3: 3017846-3.patch, failed testing. View results

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review

The failures look unrelated to the patch but I could be wrong?

fonant’s picture

fonant commented

Patch #3 fixes the HTTP 500 error in PHP 7.2 by removing the unnecessary t() functions. Works for me.

sgdev’s picture

sgdev commented
Status: Needs review » Reviewed & tested by the community

There are all types of errors in the tests causing the failures, but the main patch in #3 is right. Marking as reviewed, this is a critical problem.